Skip to content

far2l: remove PCRE, m4 and debugpy dependencies #432441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

far2l: remove PCRE, m4 and debugpy dependencies #432441

wants to merge 4 commits into from
+0 −6

Conversation

tempergate
Copy link

@tempergate tempergate commented Aug 10, 2025 •
edited
Loading

PCRE, m4 and debugpy is no longer needed as a dependency for 2.6.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@tempergate
Update package.nix
0549bd6 
PCRE is no longer needed as a dependency for 2.6.5
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 10, 2025
pluiedev
pluiedev suggested changes Aug 10, 2025
View reviewed changes
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs — please follow our contribution guidelines and rename your commit and PR accordingly to something like "far2l: remove PCRE dependency".

CI is failing since PCRE is still used on line 73.

@tempergate
far2l: remove PCRE, m4 and debugpy dependencies
7b8ed1d 
That dependencies are not  used for project build
@tempergate tempergate changed the title Update package.nix far2l: remove PCRE, m4 and debugpy dependencies Aug 11, 2025
@nix-owners nix-owners bot requested a review from hypersw August 11, 2025 04:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 11, 2025
Nyxvectar
Nyxvectar suggested changes Aug 11, 2025
View reviewed changes
Copy link

@Nyxvectar Nyxvectar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the commits history tidy, reserving only one commit far2l: remove PCRE, m4 and debugpy dependencies maybe more acceptable.

@tempergate
Copy link
Author

To keep the commits history tidy, reserving only one commit far2l: remove PCRE, m4 and debugpy dependencies maybe more acceptable.

It seems not possible without reopening mr after resseting and recreating changes. Is it really so important, is it is mr between branches?

@Nyxvectar
Copy link

To keep the commits history tidy, reserving only one commit far2l: remove PCRE, m4 and debugpy dependencies maybe more acceptable.

It seems not possible without reopening mr after resseting and recreating changes. Is it really so important, is it is mr between branches?

Well, just a habit. And there is no need to reopen ur pr, and such more ways can be taken to make, for example, git soft reset and stash, fetch, stash pop, then force push. As the pr source repo updated, this pr source will follow it. Just merge 2 commits' diff into one commit can do, then there is only one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypersw hypersw Awaiting requested review from hypersw

2 more reviewers

@pluiedev pluiedev pluiedev requested changes

@Nyxvectar Nyxvectar Nyxvectar requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tempergate @Nyxvectar @pluiedev