Skip to content

dingtalk: init at 7.6.45.5062501 #431371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dingtalk: init at 7.6.45.5062501 #431371

wants to merge 2 commits into from

Conversation

Nyxvectar
Copy link

@Nyxvectar Nyxvectar commented Aug 6, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 6, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 6, 2025
@Nyxvectar
Copy link
Author

Nyxvectar commented Aug 6, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 431371
Commit: 6450d7f37b95811aea8a4824ba61559faf275a52

x86_64-linux

✅ 1 package built:
  • dingtalk

aarch64-linux

✅ 1 package built:
  • dingtalk

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 6, 2025
acid-bong
acid-bong suggested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening and welcome to Nixpkgs. Here's a couple notes.

And a general one: in this PR only two commits should remain, new maintainer and, after it, new package.

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 6, 2025
@Nyxvectar Nyxvectar force-pushed the master branch 3 times, most recently from 4cb7b5f to 6450d7f Compare August 7, 2025 00:55
@Nyxvectar Nyxvectar requested a review from acid-bong August 7, 2025 01:25
@Nyxvectar
Copy link
Author

Evening and welcome to Nixpkgs. Here's a couple notes.

And a general one: in this PR only two commits should remain, new maintainer and, after it, new package.

Thank you for your welcome. I have kept the necessary two commits, though I forced pushed so many times (laugh

@acid-bong
Copy link
Contributor

acid-bong commented Aug 7, 2025 •
edited
Loading

The first commit's title should be "maintainers: add nyxvectar", no @

@Nyxvectar Nyxvectar force-pushed the master branch 4 times, most recently from 256707c to 8f1ee59 Compare August 7, 2025 04:30
Nyxvectar
Nyxvectar commented Aug 7, 2025
View reviewed changes
Copy link
Author

@Nyxvectar Nyxvectar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit's title should be "maintainers: add nyxvectar", no @

Done.

qzylinra
qzylinra reviewed Aug 11, 2025
View reviewed changes
@Nyxvectar Nyxvectar requested a review from qzylinra August 12, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-bong acid-bong Awaiting requested review from acid-bong

@qzylinra qzylinra Awaiting requested review from qzylinra

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyxvectar @acid-bong @qzylinra