uplift: init at 2.26.0 #431097
Open
uplift: init at 2.26.0 #431097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigmanificient
requested changes
Aug 5, 2025
|
Defelo
requested changes
Aug 11, 2025
Comment on lines
+22
to
+26
| ldflags = with finalAttrs.src; [ | ||
| "-s" | ||
| "-w" | ||
| "-X=github.com/gembaadvantage/uplift/internal/version.version=${tag}" | ||
| "-X=github.com/gembaadvantage/uplift/internal/version.gitCommit=${tag}" |
There was a problem hiding this comment.
Suggested change
| ldflags = with finalAttrs.src; [ | |
| "-s" | |
| "-w" | |
| "-X=github.com/gembaadvantage/uplift/internal/version.version=${tag}" | |
| "-X=github.com/gembaadvantage/uplift/internal/version.gitCommit=${tag}" | |
| ldflags = [ | |
| "-s" | |
| "-w" | |
| "-X=github.com/gembaadvantage/uplift/internal/version.version=v${finalAttrs.version}" | |
| "-X=github.com/gembaadvantage/uplift/internal/version.gitCommit=v${finalAttrs.version}" |
Using finalAttrs.src.tag here would break when overriding the src with something that doesn't have a tag attribute (e.g. a local path).
| and plays nicely with other tools. | ||
| ''; | ||
| homepage = "https://github.com/gembaadvantage/uplift"; | ||
| changelog = "https://github.com/gembaadvantage/uplift/releases/tag/${finalAttrs.src.tag}"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/gembaadvantage/uplift/releases/tag/${finalAttrs.src.tag}"; | |
| changelog = "https://github.com/gembaadvantage/uplift/releases/tag/v${finalAttrs.version}"; |
| workflow. It adheres to the Semantic Versioning specification | ||
| and plays nicely with other tools. | ||
| ''; | ||
| homepage = "https://github.com/gembaadvantage/uplift"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/gembaadvantage/uplift"; | |
| homepage = "https://upliftci.dev/"; | |
| downloadPage = "https://github.com/gembaadvantage/uplift"; |
There was a problem hiding this comment.
Thanks for the suggestions. #367739 is not yet resolved, and I think this is currently person preferences. I much prefer to use src.tag over version since it reduces the error in the future if the upstream changes the tag prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #427996
cc @rzsita for testing
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.