onlyoffice-desktopeditors-unwrapped: init at 9.0.0 #431070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae9678d to
5478baf
Compare
yzhou216
suggested changes
Aug 14, 2025
| ]; | ||
|
|
||
| in | ||
| stdenv.mkDerivation (self: { |
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation (self: { | |
| stdenv.mkDerivation (finalAttrs: { |
There was a problem hiding this comment.
Can you find a quotation that says why self is a bad name for this?
There was a problem hiding this comment.
Can you find a quotation that says why
selfis a bad name for this?
No, it's not bad. The most common pattern in Nixpkgs is finalAttrs so it's good to keep it that way, but it's all up to you.
| version = "9.0.3"; | ||
| minor = null; | ||
| src = fetchurl { | ||
| url = "https://github.com/ONLYOFFICE/DesktopEditors/releases/download/v${self.version}/onlyoffice-desktopeditors_amd64.deb"; |
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/ONLYOFFICE/DesktopEditors/releases/download/v${self.version}/onlyoffice-desktopeditors_amd64.deb"; | |
| url = "https://github.com/ONLYOFFICE/DesktopEditors/releases/download/v${finalAttrs.version}/onlyoffice-desktopeditors_amd64.deb"; |
Comment on lines
+125
to
+129
| mkdir -p $out/{bin,lib,share} | ||
|
|
||
| mv usr/bin/* $out/bin | ||
| mv usr/share/* $out/share/ | ||
| mv opt/onlyoffice/desktopeditors $out/share |
There was a problem hiding this comment.
Suggested change
| mkdir -p $out/{bin,lib,share} | |
| mv usr/bin/* $out/bin | |
| mv usr/share/* $out/share/ | |
| mv opt/onlyoffice/desktopeditors $out/share | |
| mkdir -p $out | |
| mv usr/{bin,share} $out | |
| mv opt/onlyoffice/desktopeditors $out/share |
Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new package
onlyoffice-desktopeditors-unwrapped, extracted frompkgs/by-name/on/onlyoffice-desktopeditors/package.nix. This allows users to useoverrideAttrson the unwrapped version of the package, and then pass it as an input toonlyoffice-desktopeditors.override.Note, I'm not exactly sure what the convention for an
-unwrappedpackage is, which hooks, if any, should be moved topkgs/by-name/on/onlyoffice-desktopeditors/package.nix?autoPatchelfHookmakeWrapperwrapGAppsHook3Also moved and updated
update.sh, and made the script executable. While I was at it, I ran the script, so this PR also updates the package from 9.0.0 to 9.0.3.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.