Skip to content

ifstate: init at 2.0.0 #431047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ifstate: init at 2.0.0 #431047

wants to merge 3 commits into from
+853 −0

Conversation

MarcelCoding
Copy link
Member

@MarcelCoding MarcelCoding commented Aug 4, 2025 •
edited
Loading

Changelog: https://codeberg.org/liske/ifstate/releases/tag/2.0.0
Website: https://ifstate.net

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@MarcelCoding
python3Packages.wgnlpy: fix exception when WGPEER_A_LAST_HANDSHAKE_TI…
4c54e18 
…ME is None

Cherry-picked from
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/83019:

> The value of a peer's last handshake NLA can be None which triggers an TypeError
> exception inside wgnlpy. This breaks ifstate from time to time when it is used
> to configure wireguard VPNs and this bug is triggered. Although a PR[1] was
> opened longer time ago the issue had not been fixed upstream, yet.
>
> [1]: ArgosyLabs/wgnlpy#5
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 4, 2025
@MarcelCoding MarcelCoding force-pushed the ifstate branch 3 times, most recently from 4cc5d74 to af0a89a Compare August 4, 2025 23:34
acid-bong
acid-bong reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the module, but have some notes on the package recipe

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 5, 2025
@felbinger felbinger mentioned this pull request Aug 5, 2025
Open
@MarcelCoding MarcelCoding force-pushed the ifstate branch 3 times, most recently from 4adbcd8 to abc0335 Compare August 7, 2025 15:15
@MarcelCoding MarcelCoding changed the title ifstate: init at 2.0.0rc4 ifstate: init at 2.0.0rc5 Aug 7, 2025
@MarcelCoding MarcelCoding force-pushed the ifstate branch 3 times, most recently from f3b589d to 0432209 Compare August 7, 2025 20:27
@MarcelCoding MarcelCoding changed the title ifstate: init at 2.0.0rc5 ifstate: init at 2.0.0rc6 Aug 7, 2025
@MarcelCoding MarcelCoding force-pushed the ifstate branch 4 times, most recently from d9f37d9 to 7fcad83 Compare August 8, 2025 21:28
@MarcelCoding MarcelCoding changed the title ifstate: init at 2.0.0rc6 ifstate: init at 2.0.0 Aug 8, 2025
@MarcelCoding MarcelCoding force-pushed the ifstate branch 2 times, most recently from 23dd64b to e0d9523 Compare August 9, 2025 10:59
MarcelCoding
MarcelCoding commented Aug 9, 2025
View reviewed changes
@MarcelCoding MarcelCoding force-pushed the ifstate branch 2 times, most recently from a4c31cb to 04db1b3 Compare August 9, 2025 11:59
@MarcelCoding MarcelCoding force-pushed the ifstate branch 2 times, most recently from 6b26932 to c0f9edf Compare August 12, 2025 20:32
SuperSandro2000
SuperSandro2000 approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already gave Marcel feedback while writing, so all my points already got addressed

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 13, 2025
@felbinger
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 431047

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/17071823565

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 6 packages built:
  • ifstate
  • ifstate.dist
  • python312Packages.wgnlpy
  • python312Packages.wgnlpy.dist
  • python313Packages.wgnlpy
  • python313Packages.wgnlpy.dist

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 6 packages built:
  • ifstate
  • ifstate.dist
  • python312Packages.wgnlpy
  • python312Packages.wgnlpy.dist
  • python313Packages.wgnlpy
  • python313Packages.wgnlpy.dist

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.wgnlpy
  • python312Packages.wgnlpy.dist
  • python313Packages.wgnlpy
  • python313Packages.wgnlpy.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.wgnlpy
  • python312Packages.wgnlpy.dist
  • python313Packages.wgnlpy
  • python313Packages.wgnlpy.dist

felbinger
felbinger approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@felbinger felbinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 19, 2025
ElvishJerricco
ElvishJerricco requested changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@ElvishJerricco ElvishJerricco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to go over the tests, but these are the things that caught my eye immediately.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

+3 more reviewers

@liske liske liske left review comments

@acid-bong acid-bong acid-bong left review comments

@felbinger felbinger felbinger approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarcelCoding @felbinger @liske @ElvishJerricco @SuperSandro2000 @acid-bong