Skip to content

sesh: fixes version command #431945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

sesh: fixes version command #431945

wants to merge 3 commits into from

Conversation

t-monaghan
Copy link

@t-monaghan t-monaghan commented Aug 8, 2025 •
edited
Loading

Includes the source revision version in the build flags so the binary is able to report the correct version when run with sesh --version.

Following the work on this PR #343041

I attempted to involve the version check as recommended here, however this fails due to sesh requiring the $HOME variable to be set at runtime, which is not possible in the nix build context as far as I'm aware. You can find my work with that here: https://github.com/t-monaghan/nixpkgs/tree/version-check.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 8, 2025
@t-monaghan t-monaghan force-pushed the adds-version-flag-to-sesh branch from 01b7361 to e3a1284 Compare August 8, 2025 07:40
@t-monaghan t-monaghan force-pushed the adds-version-flag-to-sesh branch from e3a1284 to 78beb4b Compare August 8, 2025 07:44
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 8, 2025
@nix-owners nix-owners bot requested a review from gwg313 August 8, 2025 07:51
@acid-bong
Copy link
Contributor

Maybe combine forces with #430134? cc @randomdude16671

@t-monaghan
Copy link
Author

t-monaghan commented Aug 8, 2025 •
edited
Loading

Maybe combine forces with #430134? cc @randomdude16671

Good shout @acid-bong, I've cherry-picked the commits from that PR. Let me know if there's anything else needed

Unable to cherry-pick as that breaks the verification on randomdude's commits

@t-monaghan t-monaghan changed the title sesh: update version to make sesh --version print out correct info sesh: 2.16.0 -> 2.17.1 & updates version command Aug 8, 2025
@t-monaghan t-monaghan changed the title sesh: 2.16.0 -> 2.17.1 & updates version command sesh: 2.16.0 -> 2.17.1 & fixes version command Aug 8, 2025
This was referenced Aug 8, 2025
Open
Open
Draft
@t-monaghan t-monaghan force-pushed the adds-version-flag-to-sesh branch from d0336a8 to 78beb4b Compare August 13, 2025 06:01
@t-monaghan t-monaghan changed the title sesh: 2.16.0 -> 2.17.1 & fixes version command sesh: fixes version command Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwg313 gwg313 Awaiting requested review from gwg313

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-monaghan @acid-bong