aegis-rs: init at 0.4.0 #431714
Open
aegis-rs: init at 0.4.0 #431714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieracDelta
suggested changes
Aug 7, 2025
| darwin, | ||
| }: | ||
|
|
||
| rustPlatform.buildRustPackage rec { |
There was a problem hiding this comment.
nit:
Suggested change
| rustPlatform.buildRustPackage rec { | |
| rustPlatform.buildRustPackage (finalAttrs: { |
| src = fetchFromGitHub { | ||
| owner = "Granddave"; | ||
| repo = "aegis-rs"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
nit:
Suggested change
| rev = "v${version}"; | |
| tag = "v${finalAttrs.version}"; |
Comment on lines
+31
to
+32
| darwin.apple_sdk.frameworks.Security | ||
| darwin.apple_sdk.frameworks.SystemConfiguration |
There was a problem hiding this comment.
I think apple_sdk has been migrated to apple-sdk and no longer has these attributes.
Suggested change
| darwin.apple_sdk.frameworks.Security | |
| darwin.apple_sdk.frameworks.SystemConfiguration | |
| darwin.apple-sdk |
There was a problem hiding this comment.
you shouldn't need to add darwin.apple-sdk either, its in the darwin stdenv
yzhou216
suggested changes
Aug 14, 2025
| mainProgram = "aegis-rs"; | ||
| platforms = lib.platforms.all; | ||
| }; | ||
| } |
| meta = { | ||
| description = "CLI tool for generating OTP codes from Aegis Authenticator vault backups"; | ||
| homepage = "https://github.com/Granddave/aegis-rs"; | ||
| changelog = "https://github.com/Granddave/aegis-rs/releases/tag/v${version}"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/Granddave/aegis-rs/releases/tag/v${version}"; | |
| changelog = "https://github.com/Granddave/aegis-rs/releases/tag/v${finalAttrs.version}"; |
isabelroses
reviewed
Aug 14, 2025
| license = lib.licenses.gpl3Only; | ||
| maintainers = with lib.maintainers; [ tennox ]; | ||
| mainProgram = "aegis-rs"; | ||
| platforms = lib.platforms.all; |
There was a problem hiding this comment.
rustPlatform.buildRustPackage provides a good default for this attribute
Suggested change
| platforms = lib.platforms.all; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CLI package: https://github.com/Granddave/aegis-rs/
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.