Skip to content

uroman-rs: init at 0.4.3 #431646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

uroman-rs: init at 0.4.3 #431646

wants to merge 1 commit into from

Conversation

yzhou216
Copy link
Contributor

@yzhou216 yzhou216 commented Aug 7, 2025

Things done

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 7, 2025
lafrenierejm
lafrenierejm reviewed Aug 7, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 7, 2025
@yzhou216 yzhou216 requested a review from lafrenierejm August 7, 2025 03:37
lafrenierejm
lafrenierejm reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@lafrenierejm lafrenierejm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 0.4.2 was published in the past day. Mind updating to that latest version?

@yzhou216
Copy link
Contributor Author

yzhou216 commented Aug 9, 2025

It looks like 0.4.2 was published in the past day. Mind updating to that latest version?

Fixed!

@yzhou216 yzhou216 requested a review from lafrenierejm August 9, 2025 00:22
@lafrenierejm
Copy link
Contributor

lafrenierejm commented Aug 9, 2025 •
edited
Loading

It looks like 0.4.2 was published in the past day. Mind updating to that latest version?

Fixed!

Can you update the commit message and PR description too?

EDIT: Actually, it looks like the only commit is still referencing 0.4.0. Possibly a force-push was missed?

lafrenierejm
lafrenierejm suggested changes Aug 9, 2025
View reviewed changes
@yzhou216
Copy link
Contributor Author

yzhou216 commented Aug 9, 2025

It looks like 0.4.2 was published in the past day. Mind updating to that latest version?

Fixed!

Can you update the commit message and PR description too?

EDIT: Actually, it looks like the only commit is still referencing 0.4.0. Possibly a force-push was missed?

Sorry, that was my bad. I thought I already force-pushed, but I guess I didn't. It's fixed now.

@yzhou216 yzhou216 changed the title uroman-rs: init at 0.4.0-unstable-2025-08-05 uroman-rs: init at 0.4.2-unstable-2025-08-08 Aug 9, 2025
@lafrenierejm
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 431646
Commit: eba0e5747ec85e2a663e71e83e3cb3714e0cb57f

aarch64-darwin

✅ 1 package built:
  • uroman-rs

@lafrenierejm lafrenierejm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 9, 2025
@yzhou216 yzhou216 mentioned this pull request Aug 9, 2025
Closed
@yzhou216 yzhou216 changed the title uroman-rs: init at 0.4.2-unstable-2025-08-08 uroman-rs: init at 0.4.2 Aug 9, 2025
@lafrenierejm
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 431646
Commit: 048cf0d7301598f735b9c18659c5f0a6cdb60739

aarch64-darwin

✅ 1 package built:
  • uroman-rs

@lafrenierejm
Copy link
Contributor

@yzhou216 I noticed that version 0.4.3 was released 2 days ago. Mind updating this to that latest version?

@yzhou216
Copy link
Contributor Author

@yzhou216 I noticed that version 0.4.3 was released 2 days ago. Mind updating this to that latest version?

Done

@yzhou216
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 431646

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16952675620

x86_64-linux

✅ 1 package built:
  • uroman-rs

aarch64-linux

✅ 1 package built:
  • uroman-rs

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • uroman-rs

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • uroman-rs

@lafrenierejm
Copy link
Contributor

@yzhou216 I noticed that version 0.4.3 was released 2 days ago. Mind updating this to that latest version?

Done

Thanks! Mind bumping the commit message and PR title to match?

@yzhou216
Copy link
Contributor Author

@yzhou216 I noticed that version 0.4.3 was released 2 days ago. Mind updating this to that latest version?

Done

Thanks! Mind bumping the commit message and PR title to match?

Yep, sorry I forgot about that one...

@yzhou216 yzhou216 changed the title uroman-rs: init at 0.4.2 uroman-rs: init at 0.4.3 Aug 14, 2025
@lafrenierejm
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 431646
Commit: 53a635cd9a69b93537d21a2a4a127dad6a3aeb80

aarch64-darwin

✅ 1 package built:
  • uroman-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lafrenierejm lafrenierejm lafrenierejm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhou216 @lafrenierejm