Skip to content

igs-client: init at 0-unstable-2025-07-14 #431563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

igs-client: init at 0-unstable-2025-07-14 #431563

wants to merge 1 commit into from

Conversation

dvn0
Copy link
Contributor

@dvn0 dvn0 commented Aug 6, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 6, 2025
Iamanaws
Iamanaws suggested changes Aug 7, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 7, 2025
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 7, 2025
View reviewed changes
@dvn0 dvn0 force-pushed the dvn0/igs-client-init branch 3 times, most recently from 7319bdd to 42a64b4 Compare August 8, 2025 15:54
@dvn0 dvn0 force-pushed the dvn0/igs-client-init branch from 42a64b4 to eb35de5 Compare August 8, 2025 15:59
@dvn0 dvn0 requested a review from Iamanaws August 8, 2025 16:52
@yzhou216

This comment was marked as resolved.

Sign in to view
@dvn0 dvn0 changed the title igs-client: init at 20250806-git igs-client: init at 0-unstable-2025-07-14 Aug 10, 2025
@dvn0 dvn0 requested a review from yzhou216 August 10, 2025 22:23
@yzhou216
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 431563

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16876130679

x86_64-linux

✅ 1 package built:
  • igs-client

aarch64-linux

✅ 1 package built:
  • igs-client

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • igs-client

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • igs-client

yzhou216
yzhou216 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 11, 2025
acid-bong
acid-bong reviewed Aug 11, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 14, 2025
View reviewed changes
pkgs/by-name/ig/igs-client/package.nix

buildNpmPackage (finalAttrs: {
pname = "igs-client";
version = "0-unstable-2025-07-14";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this to the latest 0-unstable-2025-08-12?

pkgs/by-name/ig/igs-client/package.nix
Comment on lines +37 to +40
mkdir -p $out/share/igs-client
cp -r ./* $out/share/igs-client

install -Dm644 $src/assets/pandanet.png $out/share/icons/hicolor/32x32/apps/igs-client.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir -p $out/share/igs-client
cp -r ./* $out/share/igs-client
install -Dm644 $src/assets/pandanet.png $out/share/icons/hicolor/32x32/apps/igs-client.png
install -Dm644 $src/assets/pandanet.png $out/share/icons/hicolor/32x32/apps/igs-client.png
cp -r . $out/share/igs-client

Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iamanaws Iamanaws Awaiting requested review from Iamanaws

2 more reviewers

@yzhou216 yzhou216 yzhou216 approved these changes

@acid-bong acid-bong acid-bong left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvn0 @yzhou216 @Iamanaws @acid-bong