Skip to content

{chow-tape-model,chow-kick}: fix build #431533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

{chow-tape-model,chow-kick}: fix build #431533

wants to merge 2 commits into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 6, 2025 •
edited
Loading

These weren't building anymore because of #427813
I removed webkit, as it seems to be unneeded: jatinchowdhury18/AnalogTapeModel#327

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 6, 2025
@Sigmanificient Sigmanificient changed the title Chow tape & chow kick: fix build {chow-tape-model,chow-kick}: fix build Aug 9, 2025
@magnetophon magnetophon mentioned this pull request Aug 16, 2025
Merged
13 tasks
@emilazy
Copy link
Member

emilazy commented Aug 18, 2025

Could you rebase for conflicts?

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 18, 2025
@magnetophon
chow-tape-model: fix build
8e4573c 
It wasn't building anymore because of NixOS#427813
Remove webkit, as it seems to be unneeded: jatinchowdhury18/AnalogTapeModel#327
@magnetophon
chow-kick: fix build
2b46d0d 
It wasn't building anymore because of NixOS#427813
Remove webkit, as it seems to be unneeded: jatinchowdhury18/AnalogTapeModel#327
@magnetophon
Copy link
Member Author

@emilazy Done.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnetophon @emilazy