Skip to content

treewide: drop Qt5 versions of Plasma, Gear, Deepin, Maui, friends #430298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Aug 21, 2025
Merged

treewide: drop Qt5 versions of Plasma, Gear, Deepin, Maui, friends #430298

merged 59 commits into from
Aug 21, 2025

Conversation

K900
Copy link
Contributor

@K900 K900 commented Aug 2, 2025 •
edited
Loading

TODO:

  • ensure everything deleted has aliases
  • add asserts for removed nixos options
  • write release notes
  • fix things people scream about

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@K900 K900 force-pushed the goodbye-plasma-5 branch 3 times, most recently from ee37ad7 to 38bfa83 Compare August 2, 2025 07:17
@K900 K900 force-pushed the goodbye-plasma-5 branch 5 times, most recently from 95ab310 to 5289ce6 Compare August 12, 2025 14:07
@K900 K900 marked this pull request as ready for review August 12, 2025 16:11
@K900
Copy link
Contributor Author

K900 commented Aug 12, 2025

This is not actually ready, but undrafting so it pings people.

@K900 K900 marked this pull request as draft August 12, 2025 16:14
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: deepin 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 8.has: documentation This PR adds or changes documentation 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Aug 12, 2025
K900 added 17 commits August 21, 2025 23:21
@K900
sierra-breeze-enhanced: drop Qt5 build
cc6479b
@K900
soundkonverter: drop
c469aa1 
Upstream is dead, depends on very EOL KDE Gear libraries
@K900
trojita: drop
5e1e648 
Upstream is dead, not ported to Qt6.
@K900
virt-manager-qt: drop
55f6142 
Upstream is dead, not ported to Qt6.
@K900
wacomtablet: drop
97b63ce 
Old Qt5 version.
@K900
libsForQt5.xwaylandvideobridge: drop
270bd9c
@K900
zombietrackergps: drop
04da94c 
Upstream is dead, not ported to Qt6.
@K900
aliases.nix: prepare for KDE 5 drops
ecc7580
@K900
mauiPackages: drop
bb4ebb7
@K900
applet-window-buttons: drop
dd94d15 
Not ported to Plasma 6.
@K900
linuxPackages.deepin-anything-module: drop
96e751a 
The rest of Deepin will also be dropped.
@K900
deepin: drop
2530323
@K900
plasmaMobileGear: drop
efce08a
@K900
plasma5: drop
ee897e6
@K900
kdeGear: drop
9d94c56
@K900
aliases.nix: be smarter about throw messages
e103989
@K900
nixos/doc/rl-2511: relnote Plasma/Gear 5 removal
9913dd1
@K900 K900 force-pushed the goodbye-plasma-5 branch from 2285a1f to 9913dd1 Compare August 21, 2025 20:21
emilazy
emilazy approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know me; I love removing things.

@emilazy emilazy merged commit 2053850 into NixOS:master Aug 21, 2025
22 checks passed
@spiage
Copy link

spiage commented Aug 21, 2025

@K900 Hi!

Is it OK?

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'kwayland-integration' missing
       at /nix/store/40hpjqbfyc4ghg1cql4m5gplnj83xy0b-source/nixos/modules/services/desktop-managers/plasma6.nix:186:9:
          185|         plasma-integration.qt5
          186|         pkgs.plasma5Packages.kwayland-integration
             |         ^
          187|         (
Traceback (most recent call last):

@K900
Copy link
Contributor Author

K900 commented Aug 21, 2025

Ugh. Hold on...

@spiage
Copy link

spiage commented Aug 21, 2025

OK, it is not hurd for me )

@K900 K900 mentioned this pull request Aug 21, 2025
Merged
13 tasks
@trofi
Copy link
Contributor

trofi commented Aug 22, 2025

Removal of nixos/tests/plasma-bigscreen.nix broke a few references in master:

$ nix build --no-link -f. nixosTests.plasma-bigscreen
error:
       … while evaluating a branch condition
         at nixos/tests/all-tests.nix:115:9:
          114|         tree:
          115|         if tree ? recurseForDerivations && tree.recurseForDerivations then
             |         ^
          116|           mapAttrs (k: findTests) (builtins.removeAttrs tree [ "recurseForDerivations" ])

       … in the left operand of the AND (&&) operator
         at nixos/tests/all-tests.nix:115:41:
          114|         tree:
          115|         if tree ? recurseForDerivations && tree.recurseForDerivations then
             |                                         ^
          116|           mapAttrs (k: findTests) (builtins.removeAttrs tree [ "recurseForDerivations" ])

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: path 'nixos/tests/plasma-bigscreen.nix' does not exist

@dbeley dbeley mentioned this pull request Aug 23, 2025
Merged
6 tasks
euank added a commit to euank/niri-flake that referenced this pull request Aug 23, 2025
@euank
niri-flake-polkit: update for qt6
99ad1f5 
Upstream nixpkgs has deleted 'libsForQt5.polkit-kde-agent' (in [this
PR](NixOS/nixpkgs#430298)).

We should also update too.
@euank euank mentioned this pull request Aug 23, 2025
Merged
sodiboo pushed a commit to sodiboo/niri-flake that referenced this pull request Aug 24, 2025
@euank @sodiboo
niri-flake-polkit: update for qt6
9ecb0e5 
Upstream nixpkgs has deleted 'libsForQt5.polkit-kde-agent' (in [this
PR](NixOS/nixpkgs#430298)).

We should also update too.
@LordGrimmauld LordGrimmauld mentioned this pull request Aug 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@philiptaron philiptaron Awaiting requested review from philiptaron

@TredwellGit TredwellGit Awaiting requested review from TredwellGit

@Ma27 Ma27 Awaiting requested review from Ma27

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

@ttuegel ttuegel Awaiting requested review from ttuegel

@alyssais alyssais Awaiting requested review from alyssais

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

@infinisil infinisil Awaiting requested review from infinisil

+1 more reviewer

@Cryolitia Cryolitia Cryolitia approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@K900 @vlinkz @wineee @spiage @trofi @vcunat @emilazy @Cryolitia @LordGrimmauld