-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
rnsh: init at 0.1.5 #430126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rnsh: init at 0.1.5 #430126
Conversation
thanks @yzhou216! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved automatically following the successful run of nixpkgs-review
.
Please squash the commits. |
done |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved automatically following the successful run of nixpkgs-review
.
pkgs/by-name/rn/rnsh/package.nix
Outdated
hash = "sha256-Dog5InfCRCxqe9pXpCAPdqGbEz2SvNOGq4BvR8oM05o="; | ||
}; | ||
|
||
doCheck = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doCheck = true; |
default in python builds. Configure nativeCheckInputs = [ pytestCheckHook ]
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing pytestCheckHook still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, sorry :D
Also it seems to cause an error:
error: builder for '/nix/store/ijhhy291glr87n55j9k8cpmpav6pwy0f-rnsh-0.1.5.drv' failed with exit code 2;
last 25 log lines:
> tests/test_rnsh.py:111
> /build/source/tests/test_rnsh.py:111: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
> @pytest.mark.asyncio
>
> tests/test_rnsh.py:159
> /build/source/tests/test_rnsh.py:159: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
> @pytest.mark.asyncio
>
> tests/test_rnsh.py:175
> /build/source/tests/test_rnsh.py:175: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
> @pytest.mark.asyncio
>
> tests/test_rnsh.py:191
> /build/source/tests/test_rnsh.py:191: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
> @pytest.mark.asyncio
>
> tests/test_rnsh.py:207
> /build/source/tests/test_rnsh.py:207: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
> @pytest.mark.asyncio
>
> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
> =========================== short test summary info ============================
> ERROR tty_test.py - TypeError: unsupported format string passed to NoneType.__format__
> !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
> ======================== 21 warnings, 1 error in 0.25s =========================
For full logs, run 'nix log /nix/store/ijhhy291glr87n55j9k8cpmpav6pwy0f-rnsh-0.1.5.drv'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means it wants pytest-asyncio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, but it still fails :'D :
> tty_test.py:5: in <module>
> print(f"{stream.name:8s} " + ("tty" if os.isatty(stream.fileno()) else "not tty"))
> E TypeError: unsupported format string passed to NoneType.__format__
> =============================== warnings summary ===============================
> rnsh/docopt.py:156
> /build/source/rnsh/docopt.py:156: SyntaxWarning: invalid escape sequence '\S'
> name = re.findall('(<\S*?>)', source)[0]
>
> rnsh/docopt.py:157
> /build/source/rnsh/docopt.py:157: SyntaxWarning: invalid escape sequence '\['
> value = re.findall('\[default: (.*)\]', source, flags=re.I)
>
> rnsh/docopt.py:198
> /build/source/rnsh/docopt.py:198: SyntaxWarning: invalid escape sequence '\['
> matched = re.findall('\[default: (.*)\]', description, flags=re.I)
>
> rnsh/docopt.py:432
> /build/source/rnsh/docopt.py:432: SyntaxWarning: invalid escape sequence '\S'
> split = re.split('\n *(<\S+?>|-\S+?)', doc)[1:]
>
> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
> =========================== short test summary info ============================
> ERROR tty_test.py - TypeError: unsupported format string passed to NoneType.__format__
> !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
> ========================= 4 warnings, 1 error in 0.34s =========================
This one doesn't seem like a missing dep, maybe tests just need to be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to be a string truncation, so f"{stream.name:.8} "
instead.
Should be good. |
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.