Skip to content

rnsh: init at 0.1.5 #430126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rnsh: init at 0.1.5 #430126

wants to merge 1 commit into from

Conversation

qbit
Copy link
Contributor

@qbit qbit commented Aug 1, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qbit qbit requested a review from fgaz August 1, 2025 13:44
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 1, 2025
@qbit
Copy link
Contributor Author

qbit commented Aug 1, 2025

thanks @yzhou216!

Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 1, 2025
@yzhou216
Copy link
Contributor

yzhou216 commented Aug 2, 2025

Please squash the commits.

@qbit
Copy link
Contributor Author

qbit commented Aug 3, 2025

Please squash the commits.

done

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 8, 2025
@yzhou216
Copy link
Contributor

yzhou216 commented Aug 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430126

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16843275179


x86_64-linux

✅ 2 packages built:
  • rnsh
  • rnsh.dist

aarch64-linux

✅ 2 packages built:
  • rnsh
  • rnsh.dist

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

hash = "sha256-Dog5InfCRCxqe9pXpCAPdqGbEz2SvNOGq4BvR8oM05o=";
};

doCheck = true;
Copy link
Member

@mweinelt mweinelt Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doCheck = true;

default in python builds. Configure nativeCheckInputs = [ pytestCheckHook ] instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing pytestCheckHook still.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, sorry :D

Also it seems to cause an error:

error: builder for '/nix/store/ijhhy291glr87n55j9k8cpmpav6pwy0f-rnsh-0.1.5.drv' failed with exit code 2;
       last 25 log lines:
       > tests/test_rnsh.py:111
       >   /build/source/tests/test_rnsh.py:111: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
       >     @pytest.mark.asyncio
       >
       > tests/test_rnsh.py:159
       >   /build/source/tests/test_rnsh.py:159: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
       >     @pytest.mark.asyncio
       >
       > tests/test_rnsh.py:175
       >   /build/source/tests/test_rnsh.py:175: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
       >     @pytest.mark.asyncio
       >
       > tests/test_rnsh.py:191
       >   /build/source/tests/test_rnsh.py:191: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
       >     @pytest.mark.asyncio
       >
       > tests/test_rnsh.py:207
       >   /build/source/tests/test_rnsh.py:207: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
       >     @pytest.mark.asyncio
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > ERROR tty_test.py - TypeError: unsupported format string passed to NoneType.__format__
       > !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
       > ======================== 21 warnings, 1 error in 0.25s =========================
       For full logs, run 'nix log /nix/store/ijhhy291glr87n55j9k8cpmpav6pwy0f-rnsh-0.1.5.drv'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means it wants pytest-asyncio.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, but it still fails :'D :

       > tty_test.py:5: in <module>
       >     print(f"{stream.name:8s} " + ("tty" if os.isatty(stream.fileno()) else "not tty"))
       > E   TypeError: unsupported format string passed to NoneType.__format__
       > =============================== warnings summary ===============================
       > rnsh/docopt.py:156
       >   /build/source/rnsh/docopt.py:156: SyntaxWarning: invalid escape sequence '\S'
       >     name = re.findall('(<\S*?>)', source)[0]
       >
       > rnsh/docopt.py:157
       >   /build/source/rnsh/docopt.py:157: SyntaxWarning: invalid escape sequence '\['
       >     value = re.findall('\[default: (.*)\]', source, flags=re.I)
       >
       > rnsh/docopt.py:198
       >   /build/source/rnsh/docopt.py:198: SyntaxWarning: invalid escape sequence '\['
       >     matched = re.findall('\[default: (.*)\]', description, flags=re.I)
       >
       > rnsh/docopt.py:432
       >   /build/source/rnsh/docopt.py:432: SyntaxWarning: invalid escape sequence '\S'
       >     split = re.split('\n *(<\S+?>|-\S+?)', doc)[1:]
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > ERROR tty_test.py - TypeError: unsupported format string passed to NoneType.__format__
       > !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
       > ========================= 4 warnings, 1 error in 0.34s =========================

This one doesn't seem like a missing dep, maybe tests just need to be disabled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to be a string truncation, so f"{stream.name:.8} " instead.

@qbit
Copy link
Contributor Author

qbit commented Aug 18, 2025

Should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants