ckb: init at 0.202.0 #430842
Open
ckb: init at 0.202.0 #430842
+61
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-bong
reviewed
Aug 4, 2025
|
acid-bong
approved these changes
Aug 4, 2025
awwpotato
reviewed
Aug 6, 2025
awwpotato
approved these changes
Aug 11, 2025
|
|
||
| cargoHash = "sha256-R7XV//e6n6afbad7HgwlcNwQRdO0xFZ0UGy1SU294Fs="; | ||
|
|
||
| buildFeatures = lib.optionals (stdenv.hostPlatform.isDarwin) [ "portable" ]; |
There was a problem hiding this comment.
No need to have parens around a single value:
Suggested change
| buildFeatures = lib.optionals (stdenv.hostPlatform.isDarwin) [ "portable" ]; | |
| buildFeatures = lib.optionals stdenv.hostPlatform.isDarwin [ "portable" ]; |
Personally, I'd format this with a multiline list, in anticipation of additional build features being specified in the future:
Suggested change
| buildFeatures = lib.optionals (stdenv.hostPlatform.isDarwin) [ "portable" ]; | |
| buildFeatures = lib.optionals stdenv.hostPlatform.isDarwin [ | |
| "portable" | |
| ]; |
But these are both nits (and/or preferences), and aren't critical.
| nativeInstallCheckInputs = [ versionCheckHook ]; | ||
|
|
||
| meta = { | ||
| description = "The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network."; |
There was a problem hiding this comment.
This is minor, but blocking:
Suggested change
| description = "The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network."; | |
| description = "Public permissionless blockchain, and the layer 1 of Nervos network"; |
See https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#meta-attributes
- Not start with the definite or an indefinite article.
- Not start with the package name.
- More generally, it should not refer to the package name.
- Not end with a period (or any punctuation for that matter).
In this case "the" is a definite article.
(Note, if needed you can include more detail and/or examples in meta.longDescription)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new package for https://github.com/nervosnetwork/ckb. a public blockchain.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.