Skip to content

llvmPackages.llvm: avoid build directory references #430776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

llvmPackages.llvm: avoid build directory references #430776

wants to merge 2 commits into from

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 3, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Aug 3, 2025
@emilazy emilazy marked this pull request as draft August 4, 2025 01:55
emilazy added 2 commits August 4, 2025 15:55
@emilazy
llvmPackages.llvm: use installCheckPhase
f82bd1a 
Otherwise we need `llvm-config(1)` to be able to find libraries in
the build directory, which means its binary has to include references
to the build directory, which means the build directory leaks into
the outputs.
@emilazy
llvmPackages.llvm: avoid build directory references
d58d153
@emilazy emilazy force-pushed the push-lsvwoltnusnl branch from 284dd08 to d58d153 Compare August 5, 2025 17:25
@emilazy emilazy marked this pull request as ready for review August 5, 2025 17:25
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 5, 2025
@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 430776 --package llvmPackages.llvm
Commit: d58d1535f55d064dfa278ff6357edfeb1c863293

aarch64-linux

✅ 4 packages built:
  • llvmPackages.llvm
  • llvmPackages.llvm.dev (llvmPackages.llvm.dev.dev, llvmPackages.llvm.dev.lib, llvmPackages.llvm.dev.python)
  • llvmPackages.llvm.lib (llvmPackages.llvm.lib.dev, llvmPackages.llvm.lib.lib, llvmPackages.llvm.lib.python)
  • llvmPackages.llvm.python (llvmPackages.llvm.python.dev, llvmPackages.llvm.python.lib, llvmPackages.llvm.python.python)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 15, 2025
alyssais
alyssais reviewed Aug 15, 2025
View reviewed changes
pkgs/development/compilers/llvm/common/llvm/llvm-config-reproducibility.patch
-set(LLVM_SRC_ROOT ${LLVM_MAIN_SRC_DIR})
-set(LLVM_OBJ_ROOT ${LLVM_BINARY_DIR})
+set(LLVM_SRC_ROOT "/no-such-path")
+set(LLVM_OBJ_ROOT "/no-such-path")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think they'd accept a patch to disable embedding this upstream?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try but I'd doubt it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing no, because the paths are used when it detects that it's being used to link things from inside the build tree - precisely to make tests work without installing, lresumably. FWIW, Buildroot patches this out too, and we already hack up llvm-config(1) a bit in our gnu-install-dirs.patch.

Possibly they'd be open to it as an opt-in flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@dtzWill dtzWill Awaiting requested review from dtzWill

@lovek323 lovek323 Awaiting requested review from lovek323

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

+1 more reviewer

@rrbutani rrbutani rrbutani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilazy @RossComputerGuy @alyssais @rrbutani