Skip to content

ycmd: unstable-2023-11-06 -> unstable-2025-06-16 #430772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ycmd: unstable-2023-11-06 -> unstable-2025-06-16 #430772

wants to merge 3 commits into from

Conversation

S0AndS0
Copy link

@S0AndS0 S0AndS0 commented Aug 3, 2025

It was discovered, while struggling with the YouCompleteMe plugin/package Issue, that sometime within the past two years the Python team made good on threats to remove cgi from the standard library.

This set of changes adds legacy-cgi to the buildInputs because the ycmd package needs cgi and, because I was already doing stuff, I updated the rev, sha256, and version attributes too ;-)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@S0AndS0 S0AndS0 changed the title Update ycmd ycmd: unstable-2023-11-06 -> unstable-2025-06-16 Aug 3, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 3, 2025
@nix-owners nix-owners bot requested review from rasendubi, melnary and LnL7 August 3, 2025 22:01
@S0AndS0 S0AndS0 mentioned this pull request Aug 4, 2025
Open
2 tasks
acid-bong
acid-bong suggested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moin and welcome to Nixpkgs. This PR of yours must be divided in 3 commits (the following aren't title examples btw):

  • version bump + dependencies
  • new maintainer entry
  • add yourself to the package maintainers

Any other edit should be amended to/squashed with its respective commit. You can force-push the resulting commits into the branch without closing the PR.

@S0AndS0
Copy link
Author

S0AndS0 commented Aug 4, 2025

Moin and welcome to Nixpkgs. This PR of yours must be divided in 3 commits (the following aren't title examples btw):

* version bump + dependencies

* new maintainer entry

* add yourself to the package maintainers

Any other edit should be amended to/squashed with its respective commit. You can force-push the resulting commits into the branch without closing the PR.

Thanks for the rapid response!

I've got the commit history adjusted as instructed, titles be based on examples found in commit history, and have corrected the sha256/hash attribute... and tested things still "work on my machine" too ;-)

If there be any other mistakes I've made, then please do call me out on 'em!

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 4, 2025
@acid-bong
Copy link
Contributor

Nah, you're good now. Just rebase onto a fresher master commit and resolve conflicts

SuperSandro2000
SuperSandro2000 reviewed Aug 4, 2025
View reviewed changes
@S0AndS0
Copy link
Author

S0AndS0 commented Aug 4, 2025

Nah, you're good now. Just rebase onto a fresher master commit and resolve conflicts

Woot! I think I got it sorted then, though probably best to not trust my thinking just yet,,, rebasing with conflicts ain't always a clean process x-)

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 4, 2025
acid-bong
acid-bong reviewed Aug 11, 2025
View reviewed changes
@acid-bong
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430772

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16870185767

x86_64-linux

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

aarch64-linux

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

acid-bong
acid-bong approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

these messages were autogenerated by Actions, which I ran before writing the latest comment. the said comment stays in power btw

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 11, 2025
SuperSandro2000
SuperSandro2000 reviewed Aug 11, 2025
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Aug 11, 2025
View reviewed changes
@S0AndS0 S0AndS0 force-pushed the update-ycmd branch 2 times, most recently from d1e8c8a to 1fb49a8 Compare August 11, 2025 18:14
@S0AndS0
ycmd: unstable-2023-11-06 -> unstable-2025-06-16
4d48a4e 
Update `version`, `rev`, and `sha256` because why not update if also
fixing dependency renaming stuff.

Add `legacy-cgi` due to breaking changes in Python updates;

- https://pypi.org/project/legacy-cgi/
- https://peps.python.org/pep-0594/#deprecated-modules
- https://peps.python.org/pep-0594/#cgi

TLDR: `cgi` was deprecated in version `3.11` and aimed to be removed in
`3.12` of Python due to;

> “[...] designed poorly and are now near-impossible to fix (`cgi`)
> [...]”

Remove `disable` attribute at request of @SuperSandro2000 because
Python2 is EOL

Add symbolic link to address Issue NixOS#429485 with YouCompleteMe Vim
plugin, however, beware there are _opportunities_ for future bug reports
to be opened because of `ycmd` and YouCompleteMe version de-sync.

Add `longDescription` with notes about YouCompleteMe errors when
run-time and compile-time Python interpreters do not match.
@S0AndS0
Copy link
Author

S0AndS0 commented Aug 27, 2025

Quick check-in with y'all, is there anything I need to do on my end to ensure things are easy to review?

@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430772
Commit: 4d48a4e93b9ffbd291b2d9ca3315848e27eed800 (subsequent changes)
Merge: b567971fb553c59ef0a0820f4340e03f885f33b0

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/17276870603

x86_64-linux

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

aarch64-linux

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • vimPlugins.YouCompleteMe
  • ycmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@rasendubi rasendubi Awaiting requested review from rasendubi

@melnary melnary Awaiting requested review from melnary

@LnL7 LnL7 Awaiting requested review from LnL7

+1 more reviewer

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S0AndS0 @acid-bong @SuperSandroBot @SuperSandro2000