gamma-launcher: init at 2.5 #430510
Open
gamma-launcher: init at 2.5 #430510
+105
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88d7477 to
7c22d8c
Compare
RossSmyth
reviewed
Aug 3, 2025
RossSmyth
suggested changes
Aug 3, 2025
RossSmyth
suggested changes
Aug 3, 2025
7c22d8c to
62df614
Compare
RossSmyth
approved these changes
Aug 3, 2025
62df614 to
a72e290
Compare
Aleksanaa
reviewed
Aug 3, 2025
a72e290 to
427481b
Compare
|
|
||
| patches = [ | ||
| (replaceVars ./use_nix_unrar_path.patch { | ||
| unrar_lib_path = "${unrar}/lib/libunrar.so"; |
There was a problem hiding this comment.
Has the library darwin support? if not meta.platforms should be adjusted accordingly or .so replaced with stdenv.hostPlatform.extensions.sharedLibrary
There was a problem hiding this comment.
I'm not sure what I need to do here, AFAIK everything here should support darwin, but evidently not working, (based on keenan's nixpkgs-review below), and I don't have a darwin system to test on.
Just disabling darwin by setting meta.platforms = lib.platforms.linux; in the python-unrar package breaks it and gamma-launcher, both are reported as being nonexistant according to nix shell
$ nix shell .#gamma-launcher
error: flake 'git+file:///home/shaun/.src/nixpkgs' does not provide attribute 'packages.x86_64-linux.gamma-launcher', 'legacyPackages.x86_64-linux.gamma-launcher' or 'gamma-launcher'
$ nix shell .#python3Packages.python-unrar
error: flake 'git+file:///home/shaun/.src/nixpkgs' does not provide attribute 'packages.x86_64-linux.python3Packages.python-unrar', 'legacyPackages.x86_64-linux.python3Packages.python-unrar' or 'python3Packages.python-unrar'
427481b to
04b2785
Compare
keenanweaver
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Anomaly & Gamma both working. I'm getting crashes in Gamma, but that's not an issue due to this package.
nixpkgs-review result for #430510
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 430510
Commit: 04b2785a3f0063639255383c8a08ecc7c3786d15 (subsequent changes)
Merge: 74478627af467aaf9d0cbadbebddac58f7e6abf0
Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/17220704928
x86_64-linux
✅ 6 packages built:
- gamma-launcher
- gamma-launcher.dist
- python312Packages.python-unrar
- python312Packages.python-unrar.dist
- python313Packages.python-unrar
- python313Packages.python-unrar.dist
aarch64-linux
✅ 6 packages built:
- gamma-launcher
- gamma-launcher.dist
- python312Packages.python-unrar
- python312Packages.python-unrar.dist
- python313Packages.python-unrar
- python313Packages.python-unrar.dist
x86_64-darwin (sandbox = true)
❌ 6 packages failed to build:
- gamma-launcher
- gamma-launcher.dist
- python312Packages.python-unrar
- python312Packages.python-unrar.dist
- python313Packages.python-unrar
- python313Packages.python-unrar.dist
Error logs: `x86_64-darwin`
python312Packages.python-unrar
==================================== ERRORS ====================================
_________________ ERROR collecting unrar/tests/test_rarfile.py _________________
unrar/tests/test_rarfile.py:22: in <module>
from unrar.rarfile import (
unrar/rarfile.py:26: in <module>
from unrar import unrarlib
unrar/unrarlib.py:54: in <module>
unrarlib = ctypes.cdll.LoadLibrary(lib_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/xb3siyaqnb0icxdjrh6frh9r8xa0wr7g-python3-3.12.11/lib/python3.12/ctypes/__init__.py:460: in LoadLibrary
return self._dlltype(name)
^^^^^^^^^^^^^^^^^^^
/nix/store/xb3siyaqnb0icxdjrh6frh9r8xa0wr7g-python3-3.12.11/lib/python3.12/ctypes/__init__.py:379: in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
E OSError: dlopen(/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/lib/libunrar.dylib, 0x0006): tried: '/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/lib/libunrar.dylib' (no such file)
=========================== short test summary info ============================
ERROR unrar/tests/test_rarfile.py - OSError: dlopen(/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/li...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.41s ===============================
python313Packages.python-unrar
==================================== ERRORS ====================================
_________________ ERROR collecting unrar/tests/test_rarfile.py _________________
unrar/tests/test_rarfile.py:22: in <module>
from unrar.rarfile import (
unrar/rarfile.py:26: in <module>
from unrar import unrarlib
unrar/unrarlib.py:54: in <module>
unrarlib = ctypes.cdll.LoadLibrary(lib_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/gkspnzkgarw4qvbl4670p3jcbgg6psrg-python3-3.13.6/lib/python3.13/ctypes/__init__.py:471: in LoadLibrary
return self._dlltype(name)
^^^^^^^^^^^^^^^^^^^
/nix/store/gkspnzkgarw4qvbl4670p3jcbgg6psrg-python3-3.13.6/lib/python3.13/ctypes/__init__.py:390: in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
E OSError: dlopen(/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/lib/libunrar.dylib, 0x0006): tried: '/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/lib/libunrar.dylib' (no such file)
=========================== short test summary info ============================
ERROR unrar/tests/test_rarfile.py - OSError: dlopen(/nix/store/c5jahf88clglgmmbg9iwdyla0bnrbck0-unrar-7.1.10/li...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.39s ===============================
aarch64-darwin (sandbox = true)
❌ 6 packages failed to build:
- gamma-launcher
- gamma-launcher.dist
- python312Packages.python-unrar
- python312Packages.python-unrar.dist
- python313Packages.python-unrar
- python313Packages.python-unrar.dist
Error logs: `aarch64-darwin`
python312Packages.python-unrar
==================================== ERRORS ====================================
_________________ ERROR collecting unrar/tests/test_rarfile.py _________________
unrar/tests/test_rarfile.py:22: in <module>
from unrar.rarfile import (
unrar/rarfile.py:26: in <module>
from unrar import unrarlib
unrar/unrarlib.py:54: in <module>
unrarlib = ctypes.cdll.LoadLibrary(lib_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/msrmjs47wva2hk6bvqzh4b40rd5n0sqx-python3-3.12.11/lib/python3.12/ctypes/__init__.py:460: in LoadLibrary
return self._dlltype(name)
^^^^^^^^^^^^^^^^^^^
/nix/store/msrmjs47wva2hk6bvqzh4b40rd5n0sqx-python3-3.12.11/lib/python3.12/ctypes/__init__.py:379: in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
E OSError: dlopen(/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/lib/libunrar.dylib, 0x0006): tried: '/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/lib/libunrar.dylib' (no such file)
=========================== short test summary info ============================
ERROR unrar/tests/test_rarfile.py - OSError: dlopen(/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/li...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.11s ===============================
python313Packages.python-unrar
==================================== ERRORS ====================================
_________________ ERROR collecting unrar/tests/test_rarfile.py _________________
unrar/tests/test_rarfile.py:22: in <module>
from unrar.rarfile import (
unrar/rarfile.py:26: in <module>
from unrar import unrarlib
unrar/unrarlib.py:54: in <module>
unrarlib = ctypes.cdll.LoadLibrary(lib_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/9px7zzsfnlmj61yy2fpl6z14w93j05is-python3-3.13.6/lib/python3.13/ctypes/__init__.py:471: in LoadLibrary
return self._dlltype(name)
^^^^^^^^^^^^^^^^^^^
/nix/store/9px7zzsfnlmj61yy2fpl6z14w93j05is-python3-3.13.6/lib/python3.13/ctypes/__init__.py:390: in __init__
self._handle = _dlopen(self._name, mode)
^^^^^^^^^^^^^^^^^^^^^^^^^
E OSError: dlopen(/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/lib/libunrar.dylib, 0x0006): tried: '/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/lib/libunrar.dylib' (no such file)
=========================== short test summary info ============================
ERROR unrar/tests/test_rarfile.py - OSError: dlopen(/nix/store/w4a2p9ixpjvzzpx36yiw1jds8fyq7fhp-unrar-7.1.10/li...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.11s ===============================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gamma-launcher, a reimplementation of the Windows-only (due to use of .NET/powershell scripts) Stalker G.A.M.M.A. launcher
also initializes
python-unrar, a required dependency for the launcherThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.