Skip to content

graalvm-oracle_25-ea: init at 25-ea-32 #430508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

graalvm-oracle_25-ea: init at 25-ea-32 #430508

merged 1 commit into from
Aug 14, 2025

Conversation

msgilligan
Copy link
Contributor

@msgilligan msgilligan commented Aug 3, 2025 •
edited
Loading

This introduces a graalvmPackages.graalvm-oracle_25-ea package that can be used for development and testing with JDK 25 and/or native-image 25.

If the community doesn't want to merge an EA version, I will try to maintain this version in a separate flake until GaalVM 25 EA is "GA" (General Availability.)

Note that I chose to use the -oracle version because binary releases are provided (and I don't think they are provided for the community version.)

This is based on PR #423224 by @farnoy

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@msgilligan msgilligan mentioned this pull request Aug 3, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: java Including JDK, tooling, other languages, other VMs labels Aug 3, 2025
@msgilligan msgilligan mentioned this pull request Aug 3, 2025
Open
@msgilligan msgilligan requested a review from farnoy August 3, 2025 01:50
@msgilligan msgilligan mentioned this pull request Aug 3, 2025
Merged
13 tasks
@msgilligan msgilligan marked this pull request as draft August 3, 2025 05:59
@msgilligan
Copy link
Contributor Author

msgilligan commented Aug 3, 2025 •
edited
Loading

@farnoy This isn't working yet and it's related to libonnxruntime.so. Whether I use your autoPatchelfIgnoreMissingDeps = [ "libonnxruntime.so.1.18.0" ]; patch or not when I try:

 NIXPKGS_ALLOW_UNFREE=1 nix shell --impure github:nixpkgs-jdk-ea/nixpkgs?ref=msgilligan/graalvm-oracle-25ea#graalvmPackages.graalvm-oracle_25-ea

I get:

      > auto-patchelf: 1 dependencies could not be satisfied
      > error: auto-patchelf could not satisfy dependency libonnxruntime.so.1 wanted by /nix/store/1v5q6akwaiwwdgzql380p6issk4yn1pm-graalvm-oracle-25-ea-31/lib/svm/profile_inference/onnx/native/libonnxruntime4j_jni.so
      > auto-patchelf failed to find all the required dependencies.
      > Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

Resolving these kind of build issues is (currently) over my head, so I'm calling it quits for the day.

@msgilligan
Copy link
Contributor Author

msgilligan commented Aug 4, 2025 •
edited
Loading

Using autoPatchelfIgnoreMissingDeps = [ "*" ]; makes it work: 9e52b39

I know this is just a workaround, but I have now tested this package on x86_64-linux, aarch64-linux, and aarch64-darwin

@msgilligan msgilligan force-pushed the msgilligan/graalvm-oracle-25ea branch from 9e52b39 to c16d82f Compare August 10, 2025 05:00
@msgilligan msgilligan changed the title graalvm-oracle_25-ea: init at 25-ea-31 graalvm-oracle_25-ea: init at 25-ea-32 Aug 10, 2025
@msgilligan
Copy link
Contributor Author

Rebased and updated to ea-32.

@farnoy
Copy link
Member

farnoy commented Aug 11, 2025

LGTM, I have no idea what the policy is on EA stuff, wouldn't be opposed to it myself.

@msgilligan msgilligan force-pushed the msgilligan/graalvm-oracle-25ea branch from e53b3bd to 0fba1bb Compare August 11, 2025 23:43
@msgilligan
Copy link
Contributor Author

msgilligan commented Aug 11, 2025 •
edited
Loading

I had to change:

autoPatchelfIgnoreMissingDeps = [ "libonnxruntime.so.1.18.0" ];

to

autoPatchelfIgnoreMissingDeps = [ "libonnxruntime.so.1" ];

and now I have removed the wildcard, I had there temporarily.

I've also rebased and squashed.

@msgilligan msgilligan marked this pull request as ready for review August 11, 2025 23:50
@msgilligan
Copy link
Contributor Author

This PR has been integrated into the https://github.com/nixpkgs-jdk-ea jdk-ea-25 branch. This allows you to run/test it with:

NIXPKGS_ALLOW_UNFREE=1 nix shell --impure github:nixpkgs-jdk-ea/nixpkgs/jdk-ea-25#graalvmPackages.graalvm-oracle_25-ea

@msgilligan msgilligan force-pushed the msgilligan/graalvm-oracle-25ea branch from 0fba1bb to b586b8f Compare August 13, 2025 06:35
@SuperSandro2000 SuperSandro2000 merged commit 6d447f5 into NixOS:master Aug 14, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnoy farnoy Awaiting requested review from farnoy

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msgilligan @farnoy @SuperSandro2000