-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
nixos/vuls: init #429283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
nixos/vuls: init #429283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current default module configuration fails because port is an integer, the toString
suggestion fixes this:
… while evaluating a path segment
at /nix/store/y0ny4hpb9hybz0q3098i9bx6gvkd2ncr-source/nixos/modules/security/vuls.nix:45:42:
44| ${pkgs.vuls}/bin/vuls server \
45| -listen=${cfg.listenAddress}:${cfg.port}
| ^
46| '';
error: cannot coerce an integer to a string: 5515
Besides this, the service fails to start because a config.toml
is needed for Vuls to actually run. We should either build this config.toml within the module or at the very least allow a user to specify a config location so they can provide their own.
I've also left two minor typo suggestions.
713cc17
to
0de640e
Compare
# Conflicts: # nixos/doc/manual/release-notes/rl-2511.section.md
0de640e
to
cb0cc1a
Compare
https://github.com/future-architect/vuls
Server for Vuls, the agent-less vulnerability scanner for Linux, FreeBSD, Container, WordPress, Programming language libraries, Network devices.
This module is not meant to allow Vuls to act as an agent. Instead the way Vuls is architected, Vuls when run as
vuls server
acts as a central hub for where vulnerability data from other vuls clients can be reported back to.Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.