Skip to content

euphonica: add updateScript, build release profile #429200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

euphonica: add updateScript, build release profile #429200

wants to merge 3 commits into from

Conversation

surfaceflinger
Copy link
Member

@surfaceflinger surfaceflinger commented Jul 28, 2025 •
edited
Loading

  • Added updateScript
  • Builds release profile instead of unoptimized dev

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from paperdigits July 28, 2025 21:57
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 28, 2025
@paperdigits
Copy link
Contributor

There is already a PR to update to the latest version here: #429036

I am unsure if buildRustPackage is better here; the code for stdEnv seems simpler IMHO.

@surfaceflinger
Copy link
Member Author

force pushed with just updatescript and release profile

@surfaceflinger surfaceflinger changed the title euphonica: update, switch to buildRustPackage, add updateScript euphonica: add updateScript, build release profile Jul 29, 2025
@liberodark
Copy link
Contributor

There is already a PR to update to the latest version here: #429036

I am unsure if buildRustPackage is better here; the code for stdEnv seems simpler IMHO.

Hi,

Yes before to update that the first work have been done.
And I changed my mind.
Thinking that might be too much of a change in my PR.

Best Regards

@surfaceflinger
Copy link
Member Author

rebased + updated to 0.96.2-beta

paperdigits
paperdigits approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@paperdigits paperdigits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues here, thank you for your efforts @surfaceflinger

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 12, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@paperdigits paperdigits paperdigits approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surfaceflinger @paperdigits @liberodark @nixos-discourse