Skip to content

ld64: fix build on case‐sensitive stores #429182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

ld64: fix build on case‐sensitive stores #429182

wants to merge 1 commit into from

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 28, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 28, 2025
@emilazy emilazy requested a review from a team July 29, 2025 17:07
SuperSandro2000
SuperSandro2000 reviewed Aug 16, 2025
View reviewed changes
pkgs/by-name/ld/ld64/patches/0006-Add-Meson-build-system.patch
@@ -299,7 +299,7 @@ index 0000000..067a69c
+ install : true,
+ sources : [
+ configure_h,
+ 'UnwindDump.cpp',
+ 'unwinddump.cpp',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably PR that to @reckenrode so that it isn't undone the next time the patches are exported https://github.com/reckenrode/ld64/blob/ld64-951.9-nixpkgs/src/other/meson.build#L72

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked him on Matrix at the time and he asked me to do it in Nixpkgs so that he could fold the changes back in on next rebase. Since he rebases the patch stack for new ld64 versions (for which there is one pending), a GitHub PR wouldn’t quite work.

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilazy @SuperSandro2000