ankiAddons.puppy-reinforcement: init at 1.1.1 #429180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethancedwards8
suggested changes
Jul 29, 2025
|
@ethancedwards8 you did the updatescript in the quizzlet importer addon, can i do the same here and is there any guideline or documentation how to use it? |
|
You can add the sand one I used |
ethancedwards8
approved these changes
Jul 29, 2025
JuneStepp
reviewed
Aug 8, 2025
| meta = { | ||
| description = "Anki add-on that encourages learners with pictures of cute puppies"; | ||
| homepage = "https://ankiweb.net/shared/info/1722658993"; | ||
| license = lib.licenses.agpl3Only; |
There was a problem hiding this comment.
| sourceRoot = "${finalAttrs.src.name}/src/puppy_reinforcement"; | ||
| passthru.updateScript = nix-update-script { }; | ||
| meta = { | ||
| description = "Anki add-on that encourages learners with pictures of cute puppies"; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JuneStepp
suggested changes
Aug 14, 2025
There was a problem hiding this comment.
Right now, this only works when withConfig is used, because the add-on expects user_files to exist. I think it would be reasonable to ensure user_files always exists instead of just when withConfig is used. I've included a diff for that change below:
diff --git a/pkgs/games/anki/addons/anki-utils.nix b/pkgs/games/anki/addons/anki-utils.nix
index 56096cf0f4c0..f27d4f511c57 100644
--- a/pkgs/games/anki/addons/anki-utils.nix
+++ b/pkgs/games/anki/addons/anki-utils.nix
@@ -54,7 +54,7 @@
installPhase = ''
runHook preInstall
- mkdir -p "$out/$installPrefix"
+ mkdir -p "$out/$installPrefix/user_files"
find . -mindepth 1 -maxdepth 1 | xargs -d'\n' mv -t "$out/$installPrefix/"
runHook postInstall
@@ -89,7 +89,6 @@
rm -f meta.json
ln -s ${addonMetaConfig} meta.json
- mkdir -p user_files
${
if (userFiles != null) then
''
|
Can you sqash your commits down to just the first two that follow the commit conventions? |
apply suggested change: rev → tag Co-authored-by: Ethan Carter Edwards <ethan@ethancedwards.com> apply suggestion: shorten description to one line add updatescript puppy-reinforcement: change license and add longDescription apply review suggestion Co-authored-by: June Stepp <git@junestepp.me> apply review suggestion simplify description Co-authored-by: June Stepp <git@junestepp.me> allways create user_files apply formatter corrections
JuneStepp
approved these changes
Aug 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
puppy-reinforcement is an addon that shows images of puppies while reviewing in a changable interval
Repo
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.