-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
kawa: init at 3.1.1 #429133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
kawa: init at 3.1.1 #429133
Conversation
@ethancedwards8 addressed, also, I'm not sure if this is the correct way to install documentation but there are also man and info files for kawa. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
cp doc/kawa.man $out/share/man/man1/kawa.1 | ||
cp doc/qexo.man $out/share/man/man1/qexo.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installManPage
from installShellFiles
might take care of this for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I use installManPage
I can't seem to do man kawa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is missing .1 file extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 is this use of copy acceptable then? Let me know if anything else needs to be changed.
cp doc/qexo.man $out/share/man/man1/qexo.1 | ||
|
||
mkdir -p $out/bin | ||
makeWrapper ${jdk11}/bin/java $out/bin/kawa \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is kawa.home
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore it seems
buildPhase = '' | ||
runHook preBuild | ||
|
||
ant -Denable-java-frontend=yes | ||
|
||
runHook postBuild | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried using the makefile in order to benefit from testing?
To be fair it does look quite over-complicated
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.