lswmi: init at 1.2.0 #429057
Open
lswmi: init at 1.2.0 #429057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Iamanaws
approved these changes
Jul 31, 2025
ethancedwards8
suggested changes
Aug 18, 2025
| version = "1.2.0"; | ||
| pyproject = true; | ||
|
|
||
| src = fetchPypi { |
There was a problem hiding this comment.
fetchFromGitHub is preferred unless there's a compelling reason, in which case add a comment
Comment on lines
+18
to
+22
| hatchling | ||
| ]; | ||
|
|
||
| nativeCheckInputs = with python3Packages; [ | ||
| pytestCheckHook |
There was a problem hiding this comment.
nit: with; is not needed here, but not blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful package for developing kernel WMI drivers — https://docs.kernel.org/wmi/driver-development-guide.html.
I've also tested the cross-compilation:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.