Skip to content

superfile: 1.3.2 -> 1.3.3; fix build #429579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

superfile: 1.3.2 -> 1.3.3; fix build #429579

merged 2 commits into from
Aug 18, 2025

Conversation

amadejkastelic
Copy link
Member

@amadejkastelic amadejkastelic commented Jul 30, 2025 •
edited
Loading

closes #429331

Fixed the build by skipping a test is only failing in nix darwin (couldn't really pinpoint what is the issue) and added a missing dependency.

Also noticed there was a new version available, so I bumped it.
Changelog: https://github.com/yorukot/superfile/releases/tag/v1.3.3

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@amadejkastelic amadejkastelic changed the title superfile-fix: 1.3.2 -> 1.3.3; fix build superfile: 1.3.2 -> 1.3.3; fix build Jul 30, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 30, 2025
@amadejkastelic
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 429579

Logs: https://github.com/amadejkastelic/nixpkgs-review-gha/actions/runs/16622575358

x86_64-linux

✅ 1 package built:
  • superfile

aarch64-linux

✅ 1 package built:
  • superfile

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • superfile

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • superfile

@amadejkastelic amadejkastelic marked this pull request as ready for review July 30, 2025 12:38
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 30, 2025
@nix-owners nix-owners bot requested review from redyf and momeemt July 30, 2025 12:56
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 30, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 18, 2025
@isabelroses isabelroses reopened this Aug 18, 2025
@isabelroses isabelroses merged commit 9c9c796 into NixOS:master Aug 18, 2025
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momeemt momeemt Awaiting requested review from momeemt

1 more reviewer

@redyf redyf redyf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: superfile
3 participants
@amadejkastelic @redyf @isabelroses