Skip to content

fosrl-olm: init at 1.0.0 #429561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2025
Merged

fosrl-olm: init at 1.0.0 #429561

merged 1 commit into from
Aug 3, 2025

Conversation

jackrosenberg
Copy link
Member

@jackrosenberg jackrosenberg commented Jul 30, 2025 •
edited
Loading

Init olm. Named fosrl-olm for consistency with fosrl-newt and fosrl-pangolin.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@jackrosenberg jackrosenberg marked this pull request as ready for review July 30, 2025 09:07
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 30, 2025
ethancedwards8
ethancedwards8 suggested changes Jul 30, 2025
View reviewed changes
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I cannot recommend that this package as it only has two stars and its unlikely that it will get much use from users of nixpkgs.

@jackrosenberg
Copy link
Member Author

Olm has been out for 12 hours, and is part of the next fossorial update. I may have jumped the gun a little marking it as ready lol. I'll draft the PR for now as to avoid unnecessary confusion, and will reopen when the update is released in the coming days :)

@ethancedwards8
Copy link
Member

Oh I see that its a dependency of something. That changes things.

We generally try to avoid adding leaf packages that won't be used by anyone, but since another package (and a very popular one at that) depends on it, this will probably be fine. Sorry for the confusion.

ethancedwards8
ethancedwards8 suggested changes Jul 30, 2025
View reviewed changes
@jackrosenberg jackrosenberg marked this pull request as draft July 30, 2025 18:26
SigmaSquadron
SigmaSquadron reviewed Jul 31, 2025
View reviewed changes
SigmaSquadron
SigmaSquadron reviewed Aug 2, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undraft. The rest of the stack has been updated.

@jackrosenberg jackrosenberg marked this pull request as ready for review August 2, 2025 08:31
SigmaSquadron
SigmaSquadron approved these changes Aug 2, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me. It's effectively identical to Newt so we don't need that much testing.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 2, 2025
adamcstephens
adamcstephens reviewed Aug 2, 2025
View reviewed changes
@jackrosenberg jackrosenberg mentioned this pull request Aug 3, 2025
Draft
13 tasks
@adamcstephens adamcstephens reopened this Aug 3, 2025
@adamcstephens
Copy link
Contributor

Forcing CI to rerun due to a format error elsewhere.

@jackrosenberg
Copy link
Member Author

Oo smart, forgot closing and reopening does that! Thanks :)

@adamcstephens adamcstephens enabled auto-merge August 3, 2025 16:02
@adamcstephens adamcstephens merged commit 944035d into NixOS:master Aug 3, 2025
43 of 49 checks passed
@jackrosenberg jackrosenberg deleted the olm branch August 3, 2025 16:06
@jackrosenberg jackrosenberg mentioned this pull request Aug 5, 2025
Merged
13 tasks
colemickens pushed a commit to colemickens/nixpkgs that referenced this pull request Aug 6, 2025
@adamcstephens @colemickens
fosrl-olm: init at 1.0.0 (NixOS#429561)
fb58e17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackrosenberg @ethancedwards8 @adamcstephens @SigmaSquadron