Skip to content

libuv: fix tests on sandboxed Darwin with recent Nix/Lix #429415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

libuv: fix tests on sandboxed Darwin with recent Nix/Lix #429415

wants to merge 1 commit into from
+77 −0

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 29, 2025

I think this is actually our regression, but we should be closing off /tmp for security reasons anyway, so I just sent a fix upstream.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 29, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 29, 2025
@emilazy emilazy requested a review from al3xtjames August 16, 2025 02:38
@emilazy emilazy force-pushed the push-xwkzqlsywnvl branch from 1cc17cd to 1000c3f Compare August 16, 2025 02:39
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 16, 2025
@emilazy emilazy force-pushed the push-xwkzqlsywnvl branch from 1000c3f to d06c035 Compare August 16, 2025 21:17
@emilazy
Copy link
Member Author

emilazy commented Aug 16, 2025

Upstream merged the patch, yay.

al3xtjames
al3xtjames suggested changes Aug 16, 2025
View reviewed changes
Copy link
Contributor

@al3xtjames al3xtjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can drop the patch file after switching to fetchpatch.

@al3xtjames
Copy link
Contributor

Hmm, I tried rebuilding libuv on b029d0b on aarch64-darwin with Lix 2.93.3 but it succeeded without this patch. The change looks fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@al3xtjames al3xtjames al3xtjames requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilazy @al3xtjames