Skip to content

equicord, equibop: updates #428217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2025
Merged

equicord, equibop: updates #428217

merged 2 commits into from
Aug 24, 2025

Conversation

qweered
Copy link
Contributor

@qweered qweered commented Jul 25, 2025 •
edited
Loading

Things done

fixes #428182

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qweered
Copy link
Contributor Author

qweered commented Jul 25, 2025

Note: withSystemEquicord = true is broken on master

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! labels Jul 25, 2025
@nix-owners nix-owners bot requested a review from NotAShelf July 25, 2025 03:22
@gepbird gepbird mentioned this pull request Aug 2, 2025
Merged
14 tasks
gepbird
gepbird approved these changes Aug 2, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the equicord update script and equibop binary, looks good and work well, thanks!

@gepbird
Copy link
Contributor

gepbird commented Aug 2, 2025

Note: withSystemEquicord = true is broken on master

Oh I just realized by default it uses equibop's version, that's unfortunate :(
Probably same changes needs to be done to equibop, as discord with equicord works in #430391

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 2, 2025
@gepbird
Copy link
Contributor

gepbird commented Aug 3, 2025 •
edited
Loading

@NotAShelf I tried out the first PR that introduced equibop and support for using system equicord (#349863), and ran into the same error:

/nix/store/dqpjqy8b6m0lb01b9jy2859sab9772nf-gvfs-1.57.2/lib/gvfs/libgvfscommon.so: undefined symbol: g_variant_builder_init_static
Failed to load module: /nix/store/dqpjqy8b6m0lb01b9jy2859sab9772nf-gvfs-1.57.2/lib/gio/modules/libgvfsdbus.so
(node:29076) UnhandledPromiseRejectionWarning: Error: Cannot find module '/nix/store/y40is2xli1v5zvlndh12i1ln3kpfrngb-equicord-1.10.4'
Require stack:
- /nix/store/4dp3jmjvjyy3ww0dm1w0722x5ny626iq-equibop-2.0.9/opt/Equibop/resources/app.asar/dist/js/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1232:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:124038)
    at Module._load (node:internal/modules/cjs/loader:1058:27)
    at c._load (node:electron/js2c/node_init:2:17025)
    at Module.require (node:internal/modules/cjs/loader:1318:19)
    at require (node:internal/modules/helpers:179:18)
    at VCDMain:26:5652
    at VCDMain:1:2813
    at Le (VCDMain:26:4946)
(Use `electron --trace-warnings ...` to show where the warning was created)
(node:29076) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

Since that feature didn't work before, I don't think it should be a blocker for merging this PR

@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 15, 2025
@gepbird
Copy link
Contributor

gepbird commented Aug 16, 2025

cc @NotAShelf can you also review this?

Just to reiterate, this PR doesn't cause new breakages, the package is broken on master using withSystemEquicord = true. Fixing that should go into it's own PR if anyone is willing to do that.

@NotAShelf
Copy link
Member

Sorry for the delay, I've been a little busy with other stuff. Please lmk if there's anything else you'd like me to review.

@pyrox0
Copy link
Member

pyrox0 commented Aug 23, 2025

equibop 2.1.6 has been released, can this be updated to that version?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 23, 2025
@gepbird
Copy link
Contributor

gepbird commented Aug 23, 2025

equibop 2.1.6 has been released, can this be updated to that version?

I think it's fine in a follow up PR, equibop and equicord is so outdated on master, I don't think we should delay the merge further.

FYI latest equicord will need to change pnpm_9 to pnpm_10, otherwise I think updates it's just a matter of bumping the version and hash. I'm happy to do the bumps after this.

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 428217
Commit: f6170e11983c999662127bcae9387646b147371c

x86_64-linux

✅ 2 packages built:
  • equibop
  • equicord

@Sigmanificient Sigmanificient merged commit 6de5fb1 into NixOS:master Aug 24, 2025
38 of 39 checks passed
@gepbird gepbird mentioned this pull request Aug 24, 2025
Merged
13 tasks
@qweered qweered deleted the equibop branch September 4, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gepbird gepbird gepbird approved these changes

@NotAShelf NotAShelf NotAShelf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Request: equibop 2.1.4 → 2.1.5
5 participants
@qweered @gepbird @NotAShelf @pyrox0 @Sigmanificient