Skip to content

various: Don't depend on libsoup2 #428043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

various: Don't depend on libsoup2 #428043

merged 5 commits into from
Jul 25, 2025

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jul 24, 2025 •
edited
Loading

cc #427813

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: mate The MATE Desktop Environment labels Jul 24, 2025
@LordGrimmauld
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 428043
Commit: fe05b6739ca768d30008cd6df5b8a23fecea5aed

x86_64-linux

✅ 10 packages built:
  • cinnamon-common
  • cinnamon-gsettings-overrides
  • cinnamon-screensaver
  • gnome-notes
  • gthumb
  • mate.caja-extensions
  • mate.caja-with-extensions
  • shotwell
  • themechanger
  • timezonemap

jtojnar
jtojnar approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, did not test.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 24, 2025
@Aleksanaa
Copy link
Member

Tested gnome-notes and gthumb. gnome-notes was broken and this fixed it.

@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 428043

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/16512488039

x86_64-linux (sandbox = true)

✅ 10 packages built:
  • cinnamon-common
  • cinnamon-gsettings-overrides
  • cinnamon-screensaver
  • gnome-notes
  • gthumb
  • mate.caja-extensions
  • mate.caja-with-extensions
  • shotwell
  • themechanger
  • timezonemap

aarch64-linux (sandbox = true)

✅ 10 packages built:
  • cinnamon-common
  • cinnamon-gsettings-overrides
  • cinnamon-screensaver
  • gnome-notes
  • gthumb
  • mate.caja-extensions
  • mate.caja-with-extensions
  • shotwell
  • themechanger
  • timezonemap

LordGrimmauld
LordGrimmauld approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks fine, the referenced issues/PRs all exist and are related. I did not run these things, but seeing as they build without libsoup now, this is probably always better than what we had before.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 25, 2025
@bobby285271 bobby285271 merged commit 38c25ff into NixOS:master Jul 25, 2025
31 of 33 checks passed
@bobby285271 bobby285271 deleted the upd/libsoup2 branch July 25, 2025 13:38
@bobby285271 bobby285271 mentioned this pull request Jul 25, 2025
Merged
13 tasks
@LordGrimmauld LordGrimmauld mentioned this pull request Jul 26, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

@mimame mimame Awaiting requested review from mimame

@hedning hedning Awaiting requested review from hedning

@romildo romildo Awaiting requested review from romildo

@mkg20001 mkg20001 Awaiting requested review from mkg20001

@dasj19 dasj19 Awaiting requested review from dasj19

Assignees
No one assigned
Labels
6.topic: mate The MATE Desktop Environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobby285271 @LordGrimmauld @Aleksanaa @jtojnar