Skip to content

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 28, 2025

Changes:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 28, 2025
@nix-owners nix-owners bot requested a review from Madouura July 28, 2025 05:46
@al3xtjames
Copy link
Contributor

I think we can drop cpuinfo from buildInputs: https://gitlab.com/AOMediaCodec/SVT-AV1/-/commit/60c308f1ace21a6d5e4fdd285a86d9d17e56c8cf

@trofi
Copy link
Contributor Author

trofi commented Aug 11, 2025

I think we can drop cpuinfo from buildInputs: https://gitlab.com/AOMediaCodec/SVT-AV1/-/commit/60c308f1ace21a6d5e4fdd285a86d9d17e56c8cf

Good catch! Pushed as:

--- a/pkgs/by-name/sv/svt-av1/package.nix
+++ b/pkgs/by-name/sv/svt-av1/package.nix
@@ -8 +7,0 @@
-  cpuinfo,
@@ -32,4 +30,0 @@ stdenv.mkDerivation (finalAttrs: {
-  buildInputs = lib.optionals stdenv.hostPlatform.isx86_64 [
-    cpuinfo
-  ];
-

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 12, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5795

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 25, 2025
@MisileLab
Copy link
Contributor

@trofi trofi changed the title svt-av1: 3.0.2 -> 3.1.0 svt-av1: 3.0.2 -> 3.1.2 Sep 1, 2025
@trofi
Copy link
Contributor Author

trofi commented Sep 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants