gtk{3,4}: get X11 out of the closure on Darwin #428426
Conversation
Not sure if we should just omit the dependency on Darwin or what, but this works…
Homebrew only does this on Linux but I don’t think there’s any reason for that.
There was a problem hiding this comment.
Looking at Meson files in at-spi2-core repo, X11 only appears to be used by three components: at-spi-bus-launcher and at-spi2-registryd (services), and libatspi (library mostly used by accessibility tools, notably: orca, chromium, gnome-shell, onboard). Only the latter makes sense as a package dependency and I doubt any of those programs work on Darwin (except for chromium – but I doubt it would be using libatspi on that platform).
Actually, I would expect ATK to be the only component needed on Darwin and that is only because it is mandatory dependency of GTK 3.
| atk | ||
| cairo | ||
| pango | ||
| (at-spi2-core.override { inherit x11Support; }) |
There was a problem hiding this comment.
did you ever decide whether to split up
at-spi2-coreagain? If it’s not happening at this point, maybe you want to do the alias migration mentioned inall-packges.nix.
It is still on the to-do list. It is just hard to do since the Meson project is monolithic.
Modern projects should not really use any of at-spi2-core libraries, e.g. GTK 4 or Odilia screen reader use the AT-SPI directly through D-Bus API. So on a future system, I would want to have package containing just the bus launcher + registry, and then have legacy packages containing atk for maintenance mode packages like GTK 3 or chromium.
libatspi might be combined with atk for simplicity. Though it would be preferable to separate it to allow ATK free systems using the accessibility tools
But not sure if it is really worth it. I guess if we decide to keep libatspi combined with atk, we can just move everything to aliases because the daemon would not be a package dependency anyway.
There was a problem hiding this comment.
Perhaps split the reorganisation out of gtk4: make x11Support actually disable X11 dependencies commit?
GTK 4 still pulls in
libX11through GraphViz through GStreamer, but meh.I haven’t tested whether this breaks
waylandSupport && !x11Support, which I fear I may have broken onstaging-nextalready. cc @LordGrimmauld who I think uses that configuration.cc @jtojnar did you ever decide whether to split up
at-spi2-coreagain? If it’s not happening at this point, maybe you want to do the alias migration mentioned inall-packges.nix.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.