grub2_efi: turn asserts into meta.broken #427180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`meta.broken` can be caught properly by CI, but asserts can not. This has the same intended effect of signaling invalid combinations of arguments.
4f30f03 to
fdadc0a
Compare
MattSturgeon
approved these changes
Jul 21, 2025
|
Successfully created backport PR for |
1 task
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta.brokencan be caught properly by CI, but asserts can not. This has the same intended effect of signaling invalid combinations of arguments.Related: #426629
Things done
Add a 👍 reaction to pull requests you find important.