Skip to content

Conversation

valentinegb
Copy link
Contributor

@valentinegb valentinegb commented Jul 21, 2025

Closes #425751.

https://modrinth.com/news/changelog/app/0.10.0
https://modrinth.com/news/changelog/app/0.10.1
https://modrinth.com/news/changelog/app/0.10.2
https://modrinth.com/news/changelog/app/0.10.3

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 21, 2025
@nix-owners nix-owners bot requested a review from getchoo July 21, 2025 05:53
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 21, 2025
@ghost
Copy link

ghost commented Jul 21, 2025

tried building this on my x86_64 nixos and it consistently fails for me with

   Compiling hickory-resolver v0.25.2
   Compiling rgb v0.8.50
   Compiling discord-rich-presence **v0.2.5**
error: theseus@1.0.0-local: Gradle build failed with exit status: 1
error: failed to run custom build command for `theseus v1.0.0-local (/build/source/packages/app-lib)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/theseus-5f7875e580f4fd03/build-script-build` (exit status: 1)
  --- stdout
  cargo::rerun-if-changed=java/gradle
  cargo::rerun-if-changed=java/src
  cargo::rerun-if-changed=java/build.gradle.kts
  cargo::rerun-if-changed=java/settings.gradle.kts
  cargo::rerun-if-changed=java/gradle.properties
  cargo::rustc-env=JAVA_JARS_DIR=/build/source/target/x86_64-unknown-linux-gnu/release/build/theseus-a8c2d4c3bef3f3b7/out/java/libs
  Downloading https://services.gradle.org/distributions/gradle-8.14.2-bin.zip

  cargo::error=Gradle build failed with exit status: 1

  --- stderr
  Exception in thread "main" java.net.UnknownHostException: services.gradle.org
        at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:567)
        at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
        at java.base/java.net.Socket.connect(Socket.java:751)
        at java.base/sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:304)
        at java.base/sun.net.NetworkClient.doConnect(NetworkClient.java:178)
        at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:531)
        at java.base/sun.net.www.http.HttpClient.openServer(HttpClient.java:636)
        at java.base/sun.net.www.protocol.https.HttpsClient.<init>(HttpsClient.java:264)
        at java.base/sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:377)
        at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:193)
        at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1252)
        at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1138)
        at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:179)
        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1690)
        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1614)
        at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:223)
        at org.gradle.wrapper.Install.forceFetch(SourceFile:2)
        at org.gradle.wrapper.Install$1.call(SourceFile:8)
        at org.gradle.wrapper.GradleWrapperMain.main(SourceFile:67)
warning: build failed, waiting for other jobs to finish...
       Error failed to build app:

@valentinegb valentinegb force-pushed the modrinth-app-unwrapped-0.10.3 branch 2 times, most recently from 7256494 to b8ad1f6 Compare July 21, 2025 19:25
@valentinegb
Copy link
Contributor Author

@Lilithmoi can you try building again? It's a bit hard for me to build for x86_64-linux

@ghost
Copy link

ghost commented Jul 21, 2025

tried again, fails but differently now

   Compiling urlencoding v2.1.3
   Compiling native-dialog v0.9.0
   Compiling sqlx v0.8.6
error: theseus@1.0.0-local: Gradle build failed with exit status: 1
error: failed to run custom build command for `theseus v1.0.0-local (/build/source/packages/app-lib)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/theseus-5f7875e580f4fd03/build-script-build` (exit status: 1)
  --- stdout
  cargo::rerun-if-changed=java/gradle
  cargo::rerun-if-changed=java/src
  cargo::rerun-if-changed=java/build.gradle.kts
  cargo::rerun-if-changed=java/settings.gradle.kts
  cargo::rerun-if-changed=java/gradle.properties
  cargo::rustc-env=JAVA_JARS_DIR=/build/source/target/x86_64-unknown-linux-gnu/release/build/theseus-a8c2d4c3bef3f3b7/out/java/libs

  Welcome to Gradle 8.14.3!

  Here are the highlights of this release:
   - Java 24 support
   - GraalVM Native Image toolchain selection
   - Enhancements to test reporting
   - Build Authoring improvements

  For more details see https://docs.gradle.org/8.14.3/release-notes.html

  Starting a Gradle Daemon (subsequent builds will be faster)
  Calculating task graph as no cached configuration is available for tasks: build
  Configuration cache entry stored.
  cargo::error=Gradle build failed with exit status: 1

  --- stderr

  FAILURE: Build failed with an exception.

  * Where:
  Settings file '/build/source/packages/app-lib/java/settings.gradle.kts' line: 1

  * What went wrong:
  Plugin [id: 'org.gradle.toolchains.foojay-resolver-convention', version: '0.10.0'] was not found in any of the following sources:

  - Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
  - Included Builds (No included builds contain this plugin)
  - Plugin Repositories (could not resolve plugin artifact 'org.gradle.toolchains.foojay-resolver-convention:org.gradle.toolchains.foojay-resolver-convention.gradle.plugin:0.10.0')
    Searched in the following repositories:
      Gradle Central Plugin Repository

  * Try:
  > Run with --stacktrace option to get the stack trace.
  > Run with --info or --debug option to get more log output.
  > Run with --scan to get full insights.
  > Get more help at https://help.gradle.org.

  BUILD FAILED in 13s
warning: build failed, waiting for other jobs to finish...
       Error failed to build app:

@valentinegb valentinegb force-pushed the modrinth-app-unwrapped-0.10.3 branch from b8ad1f6 to b265de4 Compare July 23, 2025 19:39
@valentinegb
Copy link
Contributor Author

valentinegb commented Jul 23, 2025

@Lilithmoi try building again please!

@valentinegb valentinegb force-pushed the modrinth-app-unwrapped-0.10.3 branch from b265de4 to 83ec6dc Compare July 23, 2025 19:49
@ghost
Copy link

ghost commented Jul 23, 2025

tried now with the latest changes and fails

   Compiling sha1_smol v1.0.1
   Compiling native-dialog v0.9.0
   Compiling urlencoding v2.1.3
error: theseus@1.0.0-local: Gradle build failed with exit status: 1
error: failed to run custom build command for `theseus v1.0.0-local (/build/source/packages/app-lib)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/theseus-5f7875e580f4fd03/build-script-build` (exit status: 1)
  --- stdout
  cargo::rerun-if-changed=java/gradle
  cargo::rerun-if-changed=java/src
  cargo::rerun-if-changed=java/build.gradle.kts
  cargo::rerun-if-changed=java/settings.gradle.kts
  cargo::rerun-if-changed=java/gradle.properties
  cargo::rustc-env=JAVA_JARS_DIR=/build/source/target/x86_64-unknown-linux-gnu/release/build/theseus-a8c2d4c3bef3f3b7/out/java/libs

  Welcome to Gradle 8.14.3!

  Here are the highlights of this release:
   - Java 24 support
   - GraalVM Native Image toolchain selection
   - Enhancements to test reporting
   - Build Authoring improvements

  For more details see https://docs.gradle.org/8.14.3/release-notes.html

  Starting a Gradle Daemon (subsequent builds will be faster)
  Calculating task graph as no cached configuration is available for tasks: build
  Configuration cache entry stored.
  cargo::error=Gradle build failed with exit status: 1

  --- stderr

  FAILURE: Build failed with an exception.

  * Where:
  Settings file '/build/source/packages/app-lib/java/settings.gradle.kts' line: 1

  * What went wrong:
  Plugin [id: 'org.gradle.toolchains.foojay-resolver-convention', version: '0.10.0'] was not found in any of the following sources:

  - Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
  - Included Builds (No included builds contain this plugin)
  - Plugin Repositories (could not resolve plugin artifact 'org.gradle.toolchains.foojay-resolver-convention:org.gradle.toolchains.foojay-resolver-convention.gradle.plugin:0.10.0')
    Searched in the following repositories:
      Gradle Central Plugin Repository

  * Try:
  > Run with --stacktrace option to get the stack trace.
  > Run with --info or --debug option to get more log output.
  > Run with --scan to get full insights.
  > Get more help at https://help.gradle.org.

  BUILD FAILED in 12s
warning: build failed, waiting for other jobs to finish...
       Error failed to build app:

@valentinegb valentinegb marked this pull request as draft July 24, 2025 00:52
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 24, 2025
@valentinegb
Copy link
Contributor Author

Does anyone know of a way I can get the build script for the theseus crate (packages/app-lib) in the package's source to use the bash function called gradle in Gradle's setup-hook.sh? That's what I'm struggling with at the moment ^^'

https://github.com/modrinth/code/blob/6db1d66591da292bdde0273544fbe971a1e7a37a/packages/app-lib/build.rs#L41-L51

gradle() {
local flagsArray=()
concatTo flagsArray gradleFlags gradleFlagsArray
command gradle "${flagsArray[@]}" "$@"
}

@getchoo getchoo mentioned this pull request Aug 11, 2025
13 tasks
@getchoo
Copy link
Member

getchoo commented Aug 11, 2025

Thanks for your work here :) I think I got it all cleaned up in #432663

@valentinegb valentinegb deleted the modrinth-app-unwrapped-0.10.3 branch August 12, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Request: modrinth-app-unwrapped (modrinth-app) 0.9.5 → 0.10.3
2 participants