Skip to content

nyxt: init nixos test #427912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

nyxt: init nixos test #427912

merged 1 commit into from
Aug 24, 2025

Conversation

ethancedwards8
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Jul 24, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 24, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 27, 2025
jackrosenberg
jackrosenberg approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackrosenberg
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 427912 --package nixosTests.nyxt
Commit: 39e3f4440b66b91d04a7f23c3cf894944913043b

x86_64-linux

✅ 1 test built:
  • nixosTests.nyxt

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 27, 2025
@ethancedwards8
Copy link
Member Author

@phaer any input on this PR?

@ethancedwards8 ethancedwards8 changed the title nixos/tests/nyxt: init nyxt: init nixos test Aug 12, 2025
@ethancedwards8
nixos/tests/nyxt: init
1522cd7 
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 427912
Commit: 1522cd7cacac0fcc00aadea07a82a7ab57fb9222

@phaer phaer merged commit 457564b into NixOS:master Aug 24, 2025
45 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phaer phaer Awaiting requested review from phaer

1 more reviewer

@jackrosenberg jackrosenberg jackrosenberg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethancedwards8 @jackrosenberg @Sigmanificient @phaer