Skip to content

jaq: init passthru.tests #427899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

jaq: init passthru.tests #427899

merged 1 commit into from
Aug 27, 2025
+39 −1

Conversation

ethancedwards8
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 23, 2025
jackrosenberg
jackrosenberg approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@jackrosenberg jackrosenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 27, 2025
@ethancedwards8
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 427899 --package nixosTests.jaq
Commit: d621757225ee2526e95c81b619ec1adb9ea50520

x86_64-linux

✅ 1 test built:
  • nixosTests.jaq

@ethancedwards8
Copy link
Member Author

@phaer any input on this PR?

@ethancedwards8 ethancedwards8 changed the title nixos/tests/jaq: init jaq: init nixos test Aug 12, 2025
@SigmaSquadron SigmaSquadron removed their request for review August 27, 2025 02:51
@SigmaSquadron
Copy link
Contributor

Sorry, I'm a bit overwhelmed with other PRs at the moment and cannot review this one at this time.

Sigmanificient
Sigmanificient reviewed Aug 27, 2025
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup seems a bit much for a package that does not rely on any options, i think we could simplify it by using directly a runCommand based passthru

@ethancedwards8
Copy link
Member Author

Sure. Do you have any examples? I'm not exactly sure on how to do that.

@Sigmanificient
Copy link
Member

Sigmanificient commented Aug 27, 2025 •
edited
Loading

The main idea is to use exit 1 to cause the passthru to fail, and touch $out if everything passes

nixpkgs/pkgs/by-name/ni/nixfmt-tree/package.nix

Line 122 in 7143ac6

runCommand "nixfmt-tree-test-simple"

@ethancedwards8
jaq: init passthru.tests
5051bfc 
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8 ethancedwards8 changed the title jaq: init nixos test jaq: init passthru.tests Aug 27, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Aug 27, 2025
@phaer phaer merged commit 0a726fe into NixOS:master Aug 27, 2025
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@phaer phaer Awaiting requested review from phaer

+1 more reviewer

@jackrosenberg jackrosenberg jackrosenberg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethancedwards8 @SigmaSquadron @Sigmanificient @jackrosenberg @phaer