Skip to content

nixos/p2pool: init module #427723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/p2pool: init module #427723

wants to merge 1 commit into from

Conversation

JacoMalan1
Copy link
Contributor

@JacoMalan1 JacoMalan1 commented Jul 23, 2025 •
edited
Loading

Created a service module for running p2pool as a systemd service.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch 2 times, most recently from 27b57a3 to 99dc98f Compare July 23, 2025 11:40
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 23, 2025
@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch from 99dc98f to 0ae2600 Compare July 24, 2025 07:26
jackrosenberg
jackrosenberg reviewed Jul 28, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 28, 2025
@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch from 0ae2600 to 0b3c834 Compare July 28, 2025 11:26
@JacoMalan1 JacoMalan1 requested a review from jackrosenberg July 28, 2025 11:27
@JacoMalan1
Copy link
Contributor Author

@jackrosenberg I added all of your suggestions, thanks for the review, could you check that it's correct now?

@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch from 0b3c834 to 6a6d560 Compare July 28, 2025 11:32
jackrosenberg
jackrosenberg approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 28, 2025
06kellyjac
06kellyjac reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions

@JacoMalan1
Copy link
Contributor Author

@06kellyjac I'll be having a look at your suggestions soon, at work right now, so I'll probably do it in a few hours.

@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch 2 times, most recently from 25ff00b to f04f2a8 Compare August 11, 2025 06:36
@JacoMalan1 JacoMalan1 requested a review from 06kellyjac August 11, 2025 06:36
@JacoMalan1 JacoMalan1 force-pushed the create-p2pool-service branch from f04f2a8 to fd28328 Compare August 11, 2025 06:40
@JacoMalan1
Copy link
Contributor Author

@06kellyjac I've added your suggestions, if you wouldn't mind doing another review, that would be great.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@06kellyjac 06kellyjac 06kellyjac approved these changes

@jackrosenberg jackrosenberg jackrosenberg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacoMalan1 @06kellyjac @jackrosenberg