-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
python3Packages.jax[lib]: 0.6.2 -> 0.7.1 #427588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.jax[lib]: 0.6.2 -> 0.7.1 #427588
Conversation
d4b533b
to
5558bde
Compare
1656027
to
9761641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff lgtm
b1c06d5
to
e03950b
Compare
|
e03950b
to
c6e8558
Compare
|
|
71c6e47
to
d9ba35d
Compare
nit: typo in 8778c7f commit description |
d9ba35d
to
4b03fb7
Compare
Thanks! Fixed. I still have to understand why so many numerical assertions are completely wrong now on darwin... |
Yeah, I also find that peculiar. Not your fault at least |
4a7a7cb
to
820eee4
Compare
Reported upstream: jax-ml/jax#31428 And I skipped the relevant test files on darwin. |
820eee4
to
ce3dde9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, please run nixpkgs-review.
|
38d615f
to
fd62135
Compare
This comment was marked as outdated.
This comment was marked as outdated.
fd62135
to
4746763
Compare
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @GaetanLepage ! Any remaining blockers to merge?
37aa265
to
4cfbd1d
Compare
Nope, if you're fine with the diff, feel free to press the button. This was a big one! |
Things done
Diff: jax-ml/jax@jax-v0.6.2...jax-v0.7.1
Changelogs:
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.