Skip to content

nsdiff: init at 1.85 #427461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nsdiff: init at 1.85 #427461

wants to merge 1 commit into from

Conversation

Mynacol
Copy link
Contributor

@Mynacol Mynacol commented Jul 22, 2025

Add the nsdiff package.

I found it really hard where to place this package. I settled by placing the package definition directly in perl-packages.nix and just adding a top-level alias in all-packages.nix (as it contains executable programs).
The required runtime dependencies are wrapped to not patch the source code.

TODO: Add update script (if repology isn't found/enough).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from marcusramberg, stigtsp and zakame July 22, 2025 14:26
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 22, 2025
@acid-bong
Copy link
Contributor

I found it really hard where to place this package

The current consensus is to use pkgs/by-name, unless it's a library of some sort. Does Nsdiff have any value as a library? Glancing at the source, it seems to only have three scripts

@Mynacol
Copy link
Contributor Author

Mynacol commented Jul 22, 2025

The current consensus is to use pkgs/by-name, unless it's a library of some sort. Does Nsdiff have any value as a library? Glancing at the source, it seems to only have three scripts

@acid-bong I tried to move it there. I was really unsure how this can be properly combined with the perl setup to offer it under different perl interpreter versions (perl538Packages.nsdiff and perl540Packages.nsdiff). The buildPerlPackage function is seemingly not in scope in all-packages.nix (and therefore also in pkgs/by-name?), and only in perl-packages.nix. I could use/provide a version from a fixed perl version, i.e. pkgs.perl540Packages.buildPerlPackage if that's preferred.

And while I only use it as an executable, nsdiff seems to provide a perl package potentially usable as a library, at least lib/perl5/site_perl/5.40.0/DNS/nsdiff.pm is in the output.

@acid-bong
Copy link
Contributor

nsdiff seems to provide a perl package potentially usable as a library

yeah, i saw that too. let's wait for the Perl folks to come (the bot already called them)

SuperSandro2000
SuperSandro2000 reviewed Aug 17, 2025
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Aug 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mynacol @acid-bong @SuperSandro2000