Skip to content

python3Packages.mozjpeg-lossless-optimization: rename from snake case, do some cleanup #426394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

python3Packages.mozjpeg-lossless-optimization: rename from snake case, do some cleanup #426394

wants to merge 2 commits into from
+15 −11

Conversation

TomaSajt
Copy link
Contributor

Not sure why it was added with a snake_case name: even pypi has it as skewer-case (link)

Because this has not been in any nixpkgs release other than unstable, I think we can do this rename without adding anything to python-aliases.nix

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt requested a review from adfaure July 18, 2025 13:59
@nix-owners nix-owners bot requested a review from natsukium July 18, 2025 14:00
@TomaSajt TomaSajt force-pushed the mozjpeg-lossless-optimization branch from f5b17a6 to 554793c Compare July 18, 2025 14:05
adfaure
adfaure suggested changes Jul 20, 2025
View reviewed changes
Copy link
Contributor

@adfaure adfaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to clean this code.

One small change is needed to fix KCC, and we should be good.

@TomaSajt TomaSajt force-pushed the mozjpeg-lossless-optimization branch from 554793c to af9d595 Compare July 20, 2025 12:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 20, 2025
@nix-owners nix-owners bot requested a review from dawidsowa July 20, 2025 12:10
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigmanificient Sigmanificient Sigmanificient left review comments

@natsukium natsukium Awaiting requested review from natsukium

@dawidsowa dawidsowa Awaiting requested review from dawidsowa

+1 more reviewer

@adfaure adfaure adfaure requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomaSajt @adfaure @Sigmanificient