Skip to content

sqlite: 3.50.2 -> 3.50.4 #426289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

sqlite: 3.50.2 -> 3.50.4 #426289

merged 1 commit into from
Sep 3, 2025
+5 −5

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 18, 2025 •
edited
Loading

Changes:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 18, 2025
@nix-owners nix-owners bot requested review from np and JohnAZoidberg July 18, 2025 05:54
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 18, 2025
@MisileLab
Copy link
Contributor

https://sqlite.org/releaselog/3_50_4.html released

@trofi trofi changed the title sqlite: 3.50.2 -> 3.50.3 sqlite: 3.50.2 -> 3.50.4 Aug 7, 2025
@trofi
Copy link
Contributor Author

trofi commented Aug 7, 2025

https://sqlite.org/releaselog/3_50_4.html released

Good catch! Updated to 3.50.4.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5760

martinetd
martinetd approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@martinetd martinetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(gave up part way of nixpkgs-review given the scope of this PR, but looks good for staging, and sqlite3 itself and a couple of random dependent packages (util-linux-minimal, libseccomp, python3, systemd-minimal) build fine..)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 13, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5795

@sepointon sepointon mentioned this pull request Aug 27, 2025
Open
15 tasks
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426289 --package nixVersions.latest
Commit: f2205ad7de74c5b238226f1ce6eb9f9535b4d6c4

x86_64-linux

❌ 4 packages failed to build:
  • nixVersions.latest
  • nixVersions.latest.dev (nixVersions.latest.dev.dev, nixVersions.latest.dev.doc, nixVersions.latest.dev.man)
  • nixVersions.latest.doc (nixVersions.latest.doc.dev, nixVersions.latest.doc.doc, nixVersions.latest.doc.man)
  • nixVersions.latest.man (nixVersions.latest.man.dev, nixVersions.latest.man.doc, nixVersions.latest.man.man)

@trofi
Copy link
Contributor Author

trofi commented Aug 30, 2025

nixVersions.latest

Is it a bmake dependency failure by chance?

@philiptaron
Copy link
Contributor

Is it a bmake dependency failure by chance?

Likely, though I've lost my logs to find out. I did propose a fix for the test failure in that derivation in 269f0be, part of the Nix 2.31.0 PR.

@trofi
Copy link
Contributor Author

trofi commented Sep 1, 2025

Ah, nice! I think the correct test name is interrupt. interrupt-compat seems to be a subtest of it. It fails for me just as good on x86_64-linux (on tmpfs, on a real filesystem it usually succeeds). I think it's a flaky test: it tries to SIGINT make itself.

@philiptaron philiptaron mentioned this pull request Sep 1, 2025
Merged
13 tasks
@philiptaron
Copy link
Contributor

Ah, nice! I think the correct test name is interrupt. interrupt-compat seems to be a subtest of it. It fails for me just as good on x86_64-linux (on tmpfs, on a real filesystem it usually succeeds). I think it's a flaky test: it tries to SIGINT make itself.

After reading the test code I think you're right. Let's turn it off.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5824

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 3, 2025
@philiptaron philiptaron merged commit 39842bc into NixOS:staging Sep 3, 2025
30 of 31 checks passed
@trofi trofi deleted the sqlite-update branch September 3, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@np np Awaiting requested review from np

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

+1 more reviewer

@martinetd martinetd martinetd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trofi @MisileLab @nixos-discourse @philiptaron @martinetd @SuperSandro2000