mphidflash: init at version 1.8 #426213
Open
mphidflash: init at version 1.8 #426213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethancedwards8
suggested changes
Jul 18, 2025
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp binaries/mphidflash-1.8-linux-64 $out/bin/mphidflash |
There was a problem hiding this comment.
could probably just use installBin in postInstall instead
There was a problem hiding this comment.
That would require bringing in installShellFiles as a dependency, it also doesn't make the derivation any clearer as the the project's makefile doesn't work for Nix (it tries copying files to /usr/bin/...). So it'd need to be overwritten anyways and the installed command should be renamed mphidflash.
I did make it run runHook {pre,post}Install though
Adds myself as maintainer for mphidflash package
|
I addressed your feedback, if you could take look at it again I'd be grateful! |
2d05b49 to
c668570
Compare
ethancedwards8
approved these changes
Jul 18, 2025
ghost
reviewed
Aug 8, 2025
| ''; | ||
|
|
||
| meta = { | ||
| description = "'mphidflash' is a simple command-line tool for communicating with Microchips USB HID-Bootloader and downloading new firmware."; |
There was a problem hiding this comment.
Suggested change
| description = "'mphidflash' is a simple command-line tool for communicating with Microchips USB HID-Bootloader and downloading new firmware."; | |
| description = "Command-line tool for communicating with Microchips USB HID-Bootloader and downloading new firmware"; |
Not start with the package name.
Not end with a period (or any punctuation for that matter).
There was a problem hiding this comment.
Thanks for the feedback! I implemented the change.
| owner = "AdamLaurie"; | ||
| repo = "mphidflash"; | ||
| rev = "d65bedd3f564a5d91b29e06b4a5885c32780acc5"; | ||
| sha256 = "sha256-akQjkkbGxkurBifTZuI+iVs8O2i8MM0LgMUYztg5hzE="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-akQjkkbGxkurBifTZuI+iVs8O2i8MM0LgMUYztg5hzE="; | |
| hash = "sha256-akQjkkbGxkurBifTZuI+iVs8O2i8MM0LgMUYztg5hzE="; |
use hash for sri hash
c668570 to
c897aa1
Compare
Creates a package for mphidflash. Despite mphidflash being an older tool not really being updated anymore, it remains very useful for flashing older PIC devices.
c897aa1 to
f8a133b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a package for mphidflash. Despite mphidflash being an older tool not really being updated anymore, it remains very useful for flashing older PIC devices.
More information can be found here:
https://github.com/AdamLaurie/mphidflash
I also add myself as a maintainer to the maintainers list and set myself as package maintainer.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)