Skip to content

solidtime-desktop: init at 0.0.39 #426985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solidtime-desktop: init at 0.0.39 #426985

wants to merge 1 commit into from

Conversation

hensoko
Copy link
Contributor

@hensoko hensoko commented Jul 20, 2025 •
edited
Loading

Add solidtime-desktop: https://github.com/solidtime-io/solidtime-desktop

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@hensoko hensoko self-assigned this Jul 20, 2025
@hensoko hensoko added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 20, 2025
@hensoko hensoko mentioned this pull request Jul 20, 2025
Closed
13 tasks
@hensoko hensoko marked this pull request as ready for review July 20, 2025 18:55
@hensoko hensoko force-pushed the solidtime-desktop branch 2 times, most recently from c597a79 to a56dca2 Compare July 20, 2025 19:08
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jul 20, 2025
@hensoko hensoko force-pushed the solidtime-desktop branch from a56dca2 to 841baf7 Compare July 20, 2025 19:18
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 20, 2025
@hensoko
Copy link
Contributor Author

hensoko commented Jul 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426985
Commit: 841baf7599a15d64cd22d102240407deb83eba36

x86_64-linux

✅ 1 package built:
  • solidtime-desktop

@hensoko hensoko added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 20, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 20, 2025
@hensoko hensoko requested a review from teutat3s July 20, 2025 20:57
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 20, 2025
Iamanaws
Iamanaws suggested changes Jul 21, 2025
View reviewed changes
@hensoko hensoko force-pushed the solidtime-desktop branch from 38f59fa to 8743eba Compare July 21, 2025 07:50
@hensoko hensoko requested a review from Iamanaws July 21, 2025 07:50
@hensoko
Copy link
Contributor Author

hensoko commented Jul 21, 2025

@Iamanaws thank you for your input, i squashed your suggestions and kept the Co-Author

@hensoko hensoko force-pushed the solidtime-desktop branch 2 times, most recently from 60df559 to 6ee98c3 Compare July 21, 2025 07:58
@hensoko
Copy link
Contributor Author

hensoko commented Jul 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426985
Commit: 6ee98c3aa3f59317e64500f9678449b8447a20dd

x86_64-linux

✅ 1 package built:
  • solidtime-desktop

Iamanaws
Iamanaws approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@Iamanaws Iamanaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 22, 2025
teutat3s
teutat3s reviewed Jul 24, 2025
View reviewed changes
Copy link
Member

@teutat3s teutat3s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using the finalAttrs pattern instead of rec. See buildNpmPackage nixpkgs manual section. This allows easier overriding.

teutat3s
teutat3s reviewed Jul 24, 2025
View reviewed changes
@hensoko hensoko force-pushed the solidtime-desktop branch 2 times, most recently from f90133d to 2ea5361 Compare July 24, 2025 13:31
@hensoko
Copy link
Contributor Author

hensoko commented Jul 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426985
Commit: 2ea5361f5efbffc0e17eed650daabc96770733b5

x86_64-linux

✅ 1 package built:
  • solidtime-desktop

Aleksanaa
Aleksanaa reviewed Jul 24, 2025
View reviewed changes
@hensoko hensoko force-pushed the solidtime-desktop branch 2 times, most recently from 2699ce5 to 72d8b19 Compare July 24, 2025 16:09
teutat3s
teutat3s reviewed Jul 24, 2025
View reviewed changes
@hensoko @Aleksanaa
@Iamanaws @teutat3s
solidtime-desktop: init at 0.0.39
fce9409 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Co-authored-by: Angel J <78835633+Iamanaws@users.noreply.github.com>
Co-authored-by: Jhonas Wernery <jwernery@edgecast.io>
@hensoko
Copy link
Contributor Author

hensoko commented Jul 24, 2025

Thank you all!

@hensoko hensoko force-pushed the solidtime-desktop branch from 72d8b19 to fce9409 Compare July 24, 2025 16:30
@teutat3s
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426985
Commit: fce9409a06711ecd0ee872f4004b6e83ba301e43

x86_64-linux

✅ 1 package built:
  • solidtime-desktop

teutat3s
teutat3s approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts fine.

@teutat3s teutat3s added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 12, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426985
Commit: fce9409a06711ecd0ee872f4004b6e83ba301e43

x86_64-linux

✅ 1 package built:
  • solidtime-desktop

@Sigmanificient
Copy link
Member

I cant get to login on the desktop app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

+2 more reviewers

@teutat3s teutat3s teutat3s approved these changes

@Iamanaws Iamanaws Iamanaws approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hensoko hensoko

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hensoko @teutat3s @Sigmanificient @Aleksanaa @Iamanaws