Skip to content

img4tool: init at 217 #426901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

img4tool: init at 217 #426901

merged 3 commits into from
Aug 21, 2025
+156 −31

Conversation

onny
Copy link
Contributor

@onny onny commented Jul 20, 2025 •
edited
Loading

Adding img4tool, „a tool for manipulating IMG4, IM4M and IM4P files “ (iOS firmware files)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jul 20, 2025
@onny onny marked this pull request as ready for review July 31, 2025 12:23
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 31, 2025
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
yzhou216
yzhou216 reviewed Aug 1, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 1, 2025
@yzhou216
Copy link
Contributor

yzhou216 commented Aug 1, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 426901

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16666450890

x86_64-linux

✅ 3 packages built:
  • img4tool
  • libgeneral
  • usbmuxd2

aarch64-linux

✅ 3 packages built:
  • img4tool
  • libgeneral
  • usbmuxd2

Aleksanaa
Aleksanaa reviewed Aug 1, 2025
View reviewed changes
@onny onny requested a review from Aleksanaa August 18, 2025 10:29
@onny
Copy link
Contributor Author

onny commented Aug 18, 2025

Thank you both for the feedback, fixed the issues 👍

@yzhou216
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 426901

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/17041695568

x86_64-linux

❌ 3 packages failed to build:
  • img4tool
  • libgeneral
  • usbmuxd2

aarch64-linux

❌ 3 packages failed to build:
  • img4tool
  • libgeneral
  • usbmuxd2

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • libgeneral

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • libgeneral

@onny
Copy link
Contributor Author

onny commented Aug 18, 2025

@yzhou216 Can't find the build log, can you provide me the direct link?

@yzhou216
Copy link
Contributor

https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/17041695568/job/48306801249

source> unpacking source archive /nix/build/nix-build-source.drv-4509-2741514029/download.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/n7pyvqgyrgpcvq6mchpvq82yl1dcm0ck-source.drv':
         specified: sha256-s0XKg69wSJl4dsyJaahRXoWoxHcQQGZf42v7Ni7OTdA=
            got:    sha256-67Xfq4jEK9juyaSIgVdWygAePZuyb4Yp8mY+6V66+Aw=

@onny
Copy link
Contributor Author

onny commented Aug 20, 2025

Thank you, fixed it!

@onny onny requested a review from yzhou216 August 20, 2025 13:31
@onny onny added the backport release-25.05 Backport PR automatically label Aug 21, 2025
@onny onny merged commit f94208f into NixOS:master Aug 21, 2025
27 of 29 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 21, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-426901-to-release-25.05 origin/release-25.05
cd .worktree/backport-426901-to-release-25.05
git switch --create backport-426901-to-release-25.05
git cherry-pick -x 6ec037c83bf233e4212ca810638f25e4f1c1ee7c 42b7c0db9d42bca58aaf5e704966928338985a38 be94d3f8bfb17c7906915c494940820cb8d32d17

@mdaniels5757 mdaniels5757 mentioned this pull request Aug 30, 2025
Merged
1 task
@mdaniels5757 mdaniels5757 added 8.has: port to stable This PR already has a backport to the stable release. and removed backport release-25.05 Backport PR automatically labels Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@yzhou216 yzhou216 Awaiting requested review from yzhou216

Assignees
No one assigned
Labels
8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onny @yzhou216 @Aleksanaa @mdaniels5757