Skip to content

nixos/memos: init module #426687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/memos: init module #426687

wants to merge 1 commit into from

Conversation

M0ustach3
Copy link
Contributor

Added NixOS module for memos

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jul 19, 2025
@M0ustach3 M0ustach3 force-pushed the init-memos-nixos-module branch from 010d2c9 to bc88f00 Compare July 19, 2025 15:37
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 19, 2025
acid-bong
acid-bong reviewed Jul 20, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the module looks great tho

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 20, 2025
@M0ustach3 M0ustach3 force-pushed the init-memos-nixos-module branch from bc88f00 to ec780f0 Compare July 21, 2025 07:25
@M0ustach3
Copy link
Contributor Author

Thanks for the review @acid-bong , fixed the comments in the new commit

@M0ustach3
Copy link
Contributor Author

Anyone has any idea on why the PR failed ? It only had a 500 error in one of the checks but have no idea why : https://github.com/NixOS/nixpkgs/actions/runs/16410988062/job/46365736372?pr=426687

@acid-bong
Copy link
Contributor

Close and reopen the PR

@M0ustach3 M0ustach3 closed this Jul 22, 2025
@M0ustach3 M0ustach3 reopened this Jul 22, 2025
acid-bong
acid-bong approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, CI is happy, so am I. Thx for the contribution and good luck nixing

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 12.first-time contribution This PR is the author's first one; please be gentle! labels Jul 22, 2025
@wariuccio
Copy link

Hello @M0ustach3, is there anything blocking this PR from being merged?
I'm interested in using Memos and looking forward to the module to give it a try

@M0ustach3
Copy link
Contributor Author

Hi @wariuccio , nothing is blocking the PR from being merge but, as I'm not currently a maintainer of this module, I can't merge It and (I suppose?) I have to wait for a Nix maintainer to merge it.

From what I can see, the passthru.tests on x86_64 darwin CI is still waiting from 24 days ago, don't know If this is related.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M0ustach3 @acid-bong @wariuccio