-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
foks-server: init at 0.1.2 #426432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
foks-server: init at 0.1.2 #426432
Conversation
76e7580
to
3a5f7cf
Compare
|
Interesting, looks like tailwindcss is segfaulting on x86_64 darwin: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/16419670555/job/46394482490#step:6:389 |
3a5f7cf
to
c75a72f
Compare
Fixed review comments and migrated to |
Any updates on this? It looks like the darwin-x86_64 test is still running. |
|
For the maintainers here, quick etiquette question, since this push and review foks has pushed a 1.2. Is it better for me to just bump those changes now in this PR or wait for merge and then open a new PR to bump the version? |
It's fine to update (force-push) the PR to directly package the latest version. |
Adds the foks federated key management and distribution system server.
c75a72f
to
c5a9109
Compare
|
postPatch = '' | ||
# Generate templates | ||
cd ./server/web/templates | ||
${templFoks}/bin/templ generate | ||
cd - | ||
# Generate tailwind | ||
cd ./server/web/frontend | ||
mkdir -p ../static/css | ||
${tailwindcss_4}/bin/tailwindcss -i ./css/input.css -o ../static/css/style.min.css --minify | ||
${tailwindcss_4}/bin/tailwindcss -i ./css/input.css -o ../static/css/style.css | ||
${uglify-js}/bin/uglifyjs -c < ../static/js/foks.js > ../static/js/foks.min.js | ||
cd - | ||
# Copy htmx dependency from node modules | ||
cd ./server/web/static | ||
mkdir -p ./js | ||
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.js ./js/htmx.js | ||
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.min.js ./js/htmx.min.js | ||
cd - | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postPatch = '' | |
# Generate templates | |
cd ./server/web/templates | |
${templFoks}/bin/templ generate | |
cd - | |
# Generate tailwind | |
cd ./server/web/frontend | |
mkdir -p ../static/css | |
${tailwindcss_4}/bin/tailwindcss -i ./css/input.css -o ../static/css/style.min.css --minify | |
${tailwindcss_4}/bin/tailwindcss -i ./css/input.css -o ../static/css/style.css | |
${uglify-js}/bin/uglifyjs -c < ../static/js/foks.js > ../static/js/foks.min.js | |
cd - | |
# Copy htmx dependency from node modules | |
cd ./server/web/static | |
mkdir -p ./js | |
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.js ./js/htmx.js | |
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.min.js ./js/htmx.min.js | |
cd - | |
''; | |
postPatch = | |
# Generate templates | |
'' | |
pushd ./server/web/templates | |
${templFoks}/bin/templ generate | |
popd | |
'' | |
# Generate tailwind | |
+ '' | |
pushd ./server/web/frontend | |
mkdir -p ../static/css | |
${lib.getExe tailwindcss_4} -i ./css/input.css -o ../static/css/style.min.css --minify | |
${lib.getExe tailwindcss_4} -i ./css/input.css -o ../static/css/style.css | |
${lib.getExe uglify-js} -c < ../static/js/foks.js > ../static/js/foks.min.js | |
popd | |
'' | |
# Copy htmx dependency from node modules | |
+ '' | |
pushd ./server/web/static | |
mkdir -p ./js | |
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.js ./js/htmx.js | |
cp ${foksNodeModules}/node_modules/htmx.org/dist/htmx.min.js ./js/htmx.min.js | |
popd | |
''; |
Nits (non-blocking).
lib.getExe
is preferred from hardcoding /bin/foo
. Also, prefer leaving comments outside of nix strings, so that they can be changed without triggering any rebuild.
ldflags = [ | ||
"-X main.LinkerVersion=v${finalAttrs.version}" | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeInstallCheckInputs = [ | |
versionCheckHook | |
]; | |
versionCheckProgramArg = "version"; | |
doInstallCheck = true; | |
passthru = { | |
updateScript = nix-update-script { }; | |
}; | |
Adds the foks federated key management and distribution system server.
This is the server component of #424406
Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.