Skip to content

oxidized: fix ssh support #425381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oxidized: fix ssh support #425381

wants to merge 1 commit into from

Conversation

liberodark
Copy link
Contributor

@liberodark liberodark commented Jul 15, 2025 •
edited
Loading

I was able to validate this change on my end.
The .bundle isn't suitable because it applies this locally.
So I took a more radical solution that fixes the SSH support issue, using Git.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 15, 2025
@liberodark
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425381

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/16291482637

x86_64-linux

✅ 1 package built:
  • oxidized

aarch64-linux

✅ 1 package built:
  • oxidized

@liberodark liberodark marked this pull request as ready for review July 15, 2025 16:45
@liberodark liberodark added the backport release-25.05 Backport PR automatically label Jul 15, 2025
@liberodark
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425381

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/16340480618

x86_64-linux

✅ 1 package built:
  • oxidized

aarch64-linux

✅ 1 package built:
  • oxidized

@liberodark liberodark requested a review from phaer July 21, 2025 08:17
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyuyureka yuyuyureka Awaiting requested review from yuyuyureka

@johannwagner johannwagner Awaiting requested review from johannwagner

@nicknovitski nicknovitski Awaiting requested review from nicknovitski

@n0emis n0emis Awaiting requested review from n0emis

@drupol drupol Awaiting requested review from drupol

@phaer phaer Awaiting requested review from phaer

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. backport release-25.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liberodark