tabby-terminal: init at 1.0.233 #425256
tabby-terminal: init at 1.0.233 #425256
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/process-question-on-pull-request/66456/9 |
|
Is this ready to merge yet? I wonder what is blocking... |
|
When adding a package, only two commits are needed: new maintainer, then new package. Regroup your edits |
|
|
And you've got a hash mismatch somewhere: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16709028076/job/47291215940#step:6:1369 |
| repo = "tabby"; | ||
| rev = "406e9e1"; | ||
| hash = "sha256-IMrRak6u7LRcvp2Ve2AOreNDPJM0kofMp53sKaobqO4="; | ||
| leaveDotGit = true; |
There was a problem hiding this comment.
Btw, what do you need .git for? Without cleaning .git up in the src's postBuild hook, the repo will be impure and thus unfit as a FOD
There was a problem hiding this comment.
Tabby's build command assumes its in a git repo and runs a few git commands and this was the cleanest solution I found to circumvent that. What exactly do you mean by "cleaning up" the .git folder in postBuild?
|
(Just do not close this PR again, you can force-push into the branch right away) |
Added Tabby, an electron-based terminal emulator that proclaims itself "A terminal for a more modern age".
Homepage: https://tabby.sh
Fixes #233509, previous PR #368048, but branch somehow got force overwritten
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.