64tass: init at 1.60.3243 #425210
Open
64tass: init at 1.60.3243 #425210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-bong
reviewed
Jul 15, 2025
pkgs/by-name/64/64tass/package.nix
Outdated
| meta = { | ||
| homepage = "https://tass64.sourceforge.net/"; | ||
| description = "multi pass optimizing macro assembler for the 65xx series of processors"; | ||
| license = lib.licenses.gpl2; |
There was a problem hiding this comment.
licenses.gpl# are deprecated, choose between gpl#Only or gpl#Plus (the -or-later one)
There was a problem hiding this comment.
I'm not a license expert, can you advise on which one to choose?
There was a problem hiding this comment.
Look at the source.
- If the code files contain GNU GPL header (those licenses have specific headers), which has lines
under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version., it's GPL-XXX-or-later. - Otherwise, if the build manifest (Pyproject, Cargo, Cabal, you name it) or another source of metadata (like those
metadata.xmlfiles) specifiesGPL-XXX-or-later. - Otherwise, if metadata specifies
-only, or if there's neither metadata nor headers at all, it's-only
There was a problem hiding this comment.
I believe I fixed it, there's quite a few licenses involved in the project, and I believe I did it correctly.
There was a problem hiding this comment.
What you said would be good for some nixpkgs docs
e8919d6 to
b92107e
Compare
ghost
reviewed
Aug 8, 2025
Co-authored-by: Acid Bong <acidbong@tilde.club>
e6c16e9 to
2e5f32f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.