v-analyzer: init at 0.0.6-unstable-2025-07-08 #425973
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-bong
reviewed
Jul 17, 2025
| src = fetchFromGitHub { | ||
| owner = "vlang"; | ||
| repo = "v-analyzer"; | ||
| rev = finalAttrs.version; |
There was a problem hiding this comment.
Suggested change
| rev = finalAttrs.version; | |
| tag = finalAttrs.version; |
| buildPhase = '' | ||
| runHook preBuild | ||
|
|
||
| export HOME=$(mktemp -d) |
There was a problem hiding this comment.
Suggested change
| export HOME=$(mktemp -d) |
instead, add writableTmpDirAsHomeHook to nativeBuildInputs
Comment on lines
41
to
52
| meta = with lib; { | ||
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; | ||
| homepage = "https://github.com/vlang/v-analyzer"; | ||
| changelog = "https://github.com/vlang/v-analyzer/releases/tag/${finalAttrs.version}"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ cilki ]; | ||
| platforms = platforms.unix; | ||
| mainProgram = "v-analyzer"; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; | |
| homepage = "https://github.com/vlang/v-analyzer"; | |
| changelog = "https://github.com/vlang/v-analyzer/releases/tag/${finalAttrs.version}"; | |
| license = licenses.mit; | |
| maintainers = with maintainers; [ cilki ]; | |
| platforms = platforms.unix; | |
| mainProgram = "v-analyzer"; | |
| }; | |
| meta = { | |
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; | |
| homepage = "https://github.com/vlang/v-analyzer"; | |
| changelog = "https://github.com/vlang/v-analyzer/releases/tag/${finalAttrs.version}"; | |
| license = lib.licenses.mit; | |
| maintainers = with lib.maintainers; [ cilki ]; | |
| platforms = lib.platforms.unix; | |
| mainProgram = "v-analyzer"; | |
| }; |
|
Fixed those, PTAL. |
|
And it fails to build (see the x86_64-linux build in CI) |
|
@acid-bong Yeah, you're right. I built locally with a |
acid-bong
reviewed
Jul 21, 2025
| meta = { | ||
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; | ||
| homepage = "https://github.com/vlang/v-analyzer"; | ||
| changelog = "https://github.com/vlang/v-analyzer/releases/tag/${finalAttrs.version}"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/vlang/v-analyzer/releases/tag/${finalAttrs.version}"; | |
| changelog = "https://github.com/vlang/v-analyzer/blob/${finalAttrs.src.rev}/CHANGELOG.md"; |
This way unstable commits won't lead to nonexistent tags
You mean have v compile in parallel? It seems the latest version does so by default in prod mode. |
ghost
reviewed
Aug 8, 2025
| ''; | ||
|
|
||
| meta = { | ||
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; |
There was a problem hiding this comment.
Suggested change
| description = "The @vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; | |
| description = "@vlang language server, for all your editing needs like go-to-definition, code completion, type hints, and more"; |
Not start with the definite or an indefinite article.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial v-analyzer package for IDE support with V. Closes #294566.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.