Skip to content

Conversation

ibizaman
Copy link
Contributor

@ibizaman ibizaman commented Jul 16, 2025

lldap/lldap@v0.6.1...v0.6.2

This PR precedes PR #425923 which adds first class support for the LLDAP bootstrap script.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 16, 2025
@nix-owners nix-owners bot requested a review from bendlas July 16, 2025 21:14
@ibizaman ibizaman requested a review from emilylange July 16, 2025 21:18
@emilylange emilylange removed their request for review July 17, 2025 01:12
@ibizaman ibizaman changed the title lldap: lldap 0.6.1 -> unstable-2025-07-13 lldap: lldap 0.6.1 -> unstable-2025-07-16 Jul 17, 2025
@bendlas
Copy link
Contributor

bendlas commented Jul 21, 2025

Do you think we can get upstream to do a release, instead of switching to an unstable version? cc @nitnelave

@nitnelave
Copy link

Sure, I can do a minor release. Give me a few days as things are fairly busy

@ibizaman ibizaman marked this pull request as draft July 23, 2025 17:39
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 23, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 13, 2025
@ibizaman ibizaman force-pushed the lldap-bump branch 2 times, most recently from 59b2238 to 995413b Compare August 18, 2025 21:41
@ibizaman ibizaman marked this pull request as ready for review August 18, 2025 21:42
@ibizaman
Copy link
Contributor Author

@bendlas Friendly ping since LLDAP got updated to 0.6.2.

@ibizaman ibizaman changed the title lldap: lldap 0.6.1 -> unstable-2025-07-16 lldap: lldap 0.6.1 -> 0.6.2 Aug 18, 2025
Copy link
Contributor

@bendlas bendlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still building, but lgtm.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 19, 2025
Copy link
Contributor

@bendlas bendlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get rid of the warning, so that build status can go green.

Maybe also run nixfmt on it, to make that one go brrr as well https://github.com/NixOS/nixpkgs/actions/runs/17053227263/job/48345573539?pr=425918

@ibizaman
Copy link
Contributor Author

ibizaman commented Aug 24, 2025

Btw running nix develop --command treefmt does not change any file.

EDIT: Nevermind, I checked out the wrong commit.

@nixpkgs-ci nixpkgs-ci bot added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Aug 24, 2025
@bendlas bendlas merged commit 078b5bb into NixOS:master Aug 24, 2025
27 of 31 checks passed
@ibizaman ibizaman deleted the lldap-bump branch August 24, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants