Skip to content

openutau-beta: init at 0.1.564 #425527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

openutau-beta: init at 0.1.564 #425527

wants to merge 1 commit into from
+1,336 −0

Conversation

dmkhitaryan
Copy link
Contributor

@dmkhitaryan dmkhitaryan commented Jul 15, 2025 •
edited
Loading

Description of changes

Closes #318602 by providing the pre-release/beta version of the package for https://github.com/stakira/OpenUtau, a singing synthesis platform. Is iterated upon the packaging of the release version in Nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed (for Darwin)
    • sandbox = true (for Linux)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 15, 2025
@acid-bong
Copy link
Contributor

Addresses #318602

You can make the issue close on merge by changing the wording to closes ### or fixes ###

acid-bong
acid-bong suggested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one little nitpick

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 16, 2025
@dmkhitaryan
Copy link
Contributor Author

Addresses #318602

You can make the issue close on merge by changing the wording to closes ### or fixes ###

Thank you, will keep in mind. Moreover, thank you for the suggested change, that was a good point.

@dmkhitaryan dmkhitaryan requested a review from acid-bong July 19, 2025 14:08
@acid-bong
Copy link
Contributor

Important

Squash your commits -- new items are added in Nixpkgs in one go (each!).

Only two commits should remain here (in this order): new maintainer > new package

acid-bong
acid-bong reviewed Jul 19, 2025
View reviewed changes
pkgs/by-name/op/openutau-beta/package.nix Outdated

passthru.updateScript = ./update.sh;
postPatch = ''
substituteInPlace OpenUtau/Program.cs --replace-quiet \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why replace-quiet instead of replace-fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, I think I chose the flag without intention. Come to think of it, replace-fail makes more sense... I will change that, thank you.

Copy link
Contributor Author

@dmkhitaryan dmkhitaryan Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the inconvenience. I've made the suggested changes, built the package again to confirm it's running correctly, squashed then pushed commits as requested. I hope I didn't miss anything. Thank you for your time.

@dmkhitaryan dmkhitaryan force-pushed the openutau-beta branch 3 times, most recently from 74c5b1f to b8edfcd Compare July 19, 2025 15:38
@dmkhitaryan dmkhitaryan requested a review from acid-bong July 19, 2025 16:12
acid-bong
acid-bong reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't explicitly approve (not a NET fella), but what I understand looks good

@dmkhitaryan
Copy link
Contributor Author

That's perfectly reasonable. Thank you for your guidance!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2485

@acid-bong
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425527

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16629486961

x86_64-linux

✅ 1 package built:
  • openutau-beta

aarch64-linux

✅ 1 package built:
  • openutau-beta

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openutau-beta

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openutau-beta

@acid-bong
Copy link
Contributor

@nixos/dotnet is it possible to make it build on Darwin with sandbox=true? (is it even necessary?)

acid-bong
acid-bong approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, i'll approve after the fact that it builds on Linux 👌

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 30, 2025
@dmkhitaryan
Copy link
Contributor Author

dmkhitaryan commented Aug 4, 2025 •
edited
Loading

@nixos/dotnet is it possible to make it build on Darwin with sandbox=true? (is it even necessary?)

I asked a friend for their Mac to try and build the package on darwin-aarch64. The errors were admittedly unknown to me (claimed the derivation provided a sandbox profile, which was incompatible with sanbox = true), but turns out it was a red herring.

The issue was with the postPatch phase, which also became redundant in the beta versions of this package. Removing it had allowed for successful builds with sandboxing on.

UPD: doesn't look like it solved the problem yet, hm. Guess time to look at it again...

@dmkhitaryan
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425527

Logs: https://github.com/dmkhitaryan/nixpkgs-review-gha/actions/runs/16730569849

x86_64-linux

✅ 1 package built:
  • openutau-beta

aarch64-linux

✅ 1 package built:
  • openutau-beta

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openutau-beta

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openutau-beta

@dmkhitaryan
Copy link
Contributor Author

In comparison, setting sandbox values to either relaxed or false works. I will leave it at that given the discussion here and check the relevant boxes in the original post.

nixpkgs-review result for #425527

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 425527

Logs: https://github.com/dmkhitaryan/nixpkgs-review-gha/actions/runs/16731164864

x86_64-linux

✅ 1 package built:
  • openutau-beta

aarch64-linux

✅ 1 package built:
  • openutau-beta

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openutau-beta

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openutau-beta

@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 17, 2025
@dmkhitaryan dmkhitaryan changed the title openutau-beta: init at 0.1.550 openutau-beta: init at 0.1.563 Aug 22, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 22, 2025
@dmkhitaryan dmkhitaryan changed the title openutau-beta: init at 0.1.563 openutau-beta: init at 0.1.564 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: openutau-beta
3 participants
@dmkhitaryan @acid-bong @nixos-discourse